Re: [Plplot-devel] Example 19 differences for Tcl [Solved!]

[Alan W. I. <ir...@be...>]

On 2016-01-11 07:38-0000 Arjen Markus wrote:

> Yes, I will have a look at [these example 19 differences] once the Fortran work is done. Right
now on my machine such differences are hidden by the fact that Cygwin
installation is currently missing the shapelib library.

Hi Arjen:

To resurrect this 20-day old topic, I did not see a commit from you
regarding the above plan for further action so I assume it got lost
deep on your ToDo list.  Since I was sorting out some -DPL_DOUBLE=OFF
issues with tclAPI.c in any case, I decided to fix some obvious logic
issues (i.e., if GetEntries didn't find anything tacked on to the end
of the call, the logic dropped through rather than calling c_plmap*)
myself. I also did a substantial code cleanup when figuring out the
Tcl argument lists for plmap* calls.  As a result we now (commit
855ac03) have perfect Tcl PostScript differences for all examples
(including 19) for the -DPL_DOUBLE=ON case!

However, you are more expert than I am with regard to the Tcl binding
so please carefully review the current argument list logic for
preparing the calls to c_plmap* functions to see if any further logic
issues exist and to see whether the code can be cleaned up any
further.  In particular, the current logic cleanup exposed what
appears to be some inconsistencies in where tcl_interp is set. I
frankly don't understand the tcl_interp logic so will you please take
an especially close look at that and fix those inconsistencies? (Or do
a further code cleanup to remove the tcl_interp logic altogether if it
doesn't matter?)

Thanks in advance with your help finalizing this round of changes
for tclAPI.c.

Alan

__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________