Re: [Plplot-devel] wxPLViewer can no longer be built on Linux ==> master default build issue

[Phil R. <p.d...@gm...>]

Hi Alan
I think this should be fixed. I don't have easy access to a Linux box
right now, but I have tested and the new version builds with gcc on
Cygwin.

The issue is actually a C++ syntax error and nothing to do with
wxWidgets. The short explanation is that this was GCC being stricter
than Visual studio regarding syntax. In case you are interested in the
long explanation the function wxPLplotwindow<WXWINDOW>::OnMouse is
part of a template class which inherits from the template type
WXWINDOW. In the case of wxPLViewer this type is a wxFrame. The
function GetGlientSize() is a member of wxFrame. Visual Studio
realises that the template parameter is instantiated as a wxFrame,
sees the inheritance and allows the syntax in your error message to
call wxFrame::GetClientSize(), however GCC sees the call to
GetClientSize() as part of its pre instatiation checks and cannot find
a function definition so gives an error. I am not sure if this is GCC
being overly strict or VS being overly permissive or clever. As you
can see from the error, passing the permissive flag would allow this
to compile with GCC, so who knows.

Anyway, the new syntax WXWINDOW::GetClientSize() specifies the scope
fully so there should be no worries at all there. It compiles fine on
Cygwin GCC so it should be fine on Linux GCC. If you still have any
problems let me know.

Phil

On 28 December 2015 at 23:09, Alan W. Irwin <ir...@be...> wrote:
> Hi Phil:
>
> For the current tip of master (commit 08d4864) wxPLViewer can no
> longer be built on Linux, i.e., those following our git version must
> currently use -DENABLE_wxwidgets=OFF in order to build the master
> branch. Because this is a default build issue for the master branch
> that affects a considerable number of people who are attempting to use
> the master tip version, I hope we will be able to find a fix in short
> order.  The last time I attempted to build the master branch was some
> time ago, but I am pretty sure this build issue has been introduced by
> your most recent wxwidgets change, but if there is any uncertainty
> about which of your commits caused the issue, git bisect is your friend.
>
> To help you figure out this build issue, I have attached a compressed
> version of the output results from
>
> make VERBOSE=1 wxPLViewer >& wxPLViewer.out
>
> I ran that command after an initial attempt with VERBOSE=1 not set
> failed. In other words, all prerequisites have already been built, and
> wxPLViewer.out just gives the VERBOSE=1 part of the build that failed.
>
> In case this is a wxWidgets versioning issue, I currently have installed
> on my Debian Jessie platform the following wx-related packages:
>
> irwin@raven> dpkg --list |grep -i wx
> ii  libwxbase3.0-0:amd64                  3.0.2-1+b1
> amd64        wxBase library (runtime) - non-GUI support classes of wxWidgets
> toolkit
> ii  libwxbase3.0-dev                      3.0.2-1+b1
> amd64        wxBase library (development) - non-GUI support classes of
> wxWidgets toolkit
> ii  libwxgtk3.0-0:amd64                   3.0.2-1+b1
> amd64        wxWidgets Cross-platform C++ GUI toolkit (GTK+ runtime)
> ii  libwxgtk3.0-dev                       3.0.2-1+b1
> amd64        wxWidgets Cross-platform C++ GUI toolkit (GTK+ development)
> ii  wx-common                             3.0.2-1+b1
> amd64        wxWidgets Cross-platform C++ GUI toolkit (common support files)
> ii  wx3.0-headers                         3.0.2-1+b1
> amd64        wxWidgets Cross-platform C++ GUI toolkit (header files)
>
> Good luck figuring this out, and let me know if there is any
> additional information I need to supply.
>
> Alan
> __________________________
> Alan W. Irwin
>
> Astronomical research affiliation with Department of Physics and Astronomy,
> University of Victoria (astrowww.phys.uvic.ca).
>
> Programming affiliations with the FreeEOS equation-of-state
> implementation for stellar interiors (freeeos.sf.net); the Time
> Ephemerides project (timeephem.sf.net); PLplot scientific plotting
> software package (plplot.sf.net); the libLASi project
> (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
> and the Linux Brochure Project (lbproject.sf.net).
> __________________________
>
> Linux-powered Science
> __________________________