From: Orion P. <or...@co...> - 2015-11-02 02:54:14
|
On 10/31/2015 11:10 AM, Alan W. Irwin wrote: > Hi Orion: > > Thanks for implementing Brad's suggestion to fix the PLplot Ada > language support issue for CMake-3.4. To help give you PLplot git > credit for your work, would you please put the patch in "git > format-patch" form? Attached. > I also notice substantial use of <FLAGS> in the PLplot D language > support case. I assume your tests did not reveal any issues for D > because you were not trying any D compiler flags, but I predict if you > do that, you will encounter the same problem. For example, if you try > > export DFLAGS=-Iwhatever > > I assume that (harmless) compile flag will correctly propagate to the D > compile step (as seen > by the VERBOSE=1 option for make) for older versions of CMake but will > not propagate correctly for CMake-3.4. > > Anyhow, I am virtually positive there is also a PLplot <FLAGS> D > language support issue for CMake-3.4 so if you don't beat me to it, I > plan (likely late next week because I am currently tied up with > something else) to expose that issue with a test like the one I > suggested above and also plan to fix the issue following Brad's > suggestion. I don't enable D support on the Fedora package, so I haven't looked at this. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane or...@co... Boulder, CO 80301 http://www.cora.nwra.com |