Re: [Plplot-devel] Bug fix to plbuf.c

[Jim D. <ji...@di...>]

> On Jun 22, 2015, at 1:50 PM, Alan W. Irwin <ir...@be...> wrote:
> 
>> On 2015-06-21 23:50-0400 Jim Dishaw wrote:
>> 
>> I fixed the compilation error on cairo.c and I am working on a fix to cairo so that it actually resizes the plot (at least for xcairo, not sure when I can fix wincairo) when the window changes size.
>> 
>> I will also take a look at xwin when I get a chance.  I think the problem has to do with the sequencing of the events.
>> 
>> I pushed the changes to the repository.
> 
> Hi Jim:
> 
> Thanks very much for that work, and I am looking forward to your further
> work on cairo.c and xwin.c.
> 
> There are three minor issues with your current push which you will
> likely want to address for your future pushes.
> 
> 1. The results needed to be styled which I did (8025ebe).  I emphasize
> that is no trouble for me, and I am willing to do that indefinitely,
> but it does mean your rebasing in future can get complicated if any of
> those white space styling changes I make are in an area of the file
> you are working on.  Therefore, to avoid that potential issue I
> suggest you contact Phil to figure out how to style your further
> commits on Windows (and me if you want to style your further commits
> on your OS X box).

I ran scripts/style_sources.sh on my Mac. I do all my commits from that machine. I see it list the files that I have changed. Perhaps it is silently failing?  I will try to single-step the script. 

> 
> 2. The commit message had no separate short initial line summarizing
> the commit. That style of commit message is recommended in both
> <http://who-t.blogspot.be/2009/12/on-commit-messages.html> and [Pro
> Git Book](http://git-scm.com/book). The reason for that recommendation
> is many git tools make use of the first separate line of the commit
> message to help identify commits for humans.

The browse tool shows my commit message. Do I need to make it more descriptive?

> 
> 3. When I styled your changes, my git software recognized there was
> a permissions issue on one of the files you changed, i.e.,
> 
> mode change 100755 => 100644 drivers/wingcc.c
> 

I think that is an artifact of moving the file from the windows machine to the mac. 

> Note, as far as I am aware we (including Arjen and Phil on Windows and
> me on Linux) are all just using the default configuration of git on
> our various platforms, and this is the first time a permissions issue
> has occurred. I think the reason permission bits are normally not an
> issue with git is it is quite smart about default permissions for
> various file types.  In particular files with a ".c" suffix should
> never have an execute permission assigned by default with git unless
> the user does something specific to override that default.
> 
> Alan
> __________________________
> Alan W. Irwin
> 
> Astronomical research affiliation with Department of Physics and Astronomy,
> University of Victoria (astrowww.phys.uvic.ca).
> 
> Programming affiliations with the FreeEOS equation-of-state
> implementation for stellar interiors (freeeos.sf.net); the Time
> Ephemerides project (timeephem.sf.net); PLplot scientific plotting
> software package (plplot.sf.net); the libLASi project
> (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
> and the Linux Brochure Project (lbproject.sf.net).
> __________________________
> 
> Linux-powered Science
> __________________________