Re: [Plplot-general] memqt alone

[Aaron H. <he...@co...>]

Alan

Thanks for the explanation.  I've attached a patch, but I must caveat that
it's only been tested in the limited context of my application.  In
particular I'm concerned that the code I stripped out of qt.cmake is there
for some good reason, but I can't figure out what that is.

Thanks,

Aaron.

-----Original Message-----
From: Alan W. Irwin [mailto:ir...@be...] 
Sent: Thursday, May 07, 2015 7:57 PM
To: he...@co...
Cc: plp...@li...
Subject: Re: [Plplot-general] memqt alone

On 2015-05-07 19:08-0000 he...@co... wrote:

> I've been working at cutting down the size of my PLplot Windows 
> application which uses memqt. In trying to cut out all the non-memqt Qt
devices, I've discovered some possible bugs.
> 
> I'll get some more details, but briefly, there are a few places where 
> PLD_memqt was left out of conditional compilation macros for Qt raster 
> code. There is also a similar omission in the cmakelist file. Then, 
> there is other cmake code that turns off all Qt devices if PLD_extqt is
not defined. That didn't make sense to me so I commented that out. What I
ended up with seems to work fine with just the memqt device.

Hi Aaron:

For corner cases like this one (memqt only) which we ordinarily do not test,
any build system, code, and testing help you could give us would be much
appreciated.

Once you are ready to submit your proposed changes to us, we would prefer
you do that by attaching the file that is created by the "git format-patch"
command.  That file will contain all details of each of your commits. For
more about that command and also git from the PLplot prospective, please see
README.developers.

This method of submitting changes is only a strong recommendation and not
absolutely necessary if you don't have "git format-patch"/"git am"
experience yet or prefer not to learn how to use those commands.
However, the advantage of that method of submitting your changes is it
facilitates us tweaking your changes further for you to try out (using the
"git format-patch"/"git am" combination of commands, see README.developers).
Also once your changes are finalized in collaboration with us, you will
automatically get credit for your work when we push it to our repository
master branch tip.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state implementation
for stellar interiors (freeeos.sf.net); the Time Ephemerides project
(timeephem.sf.net); PLplot scientific plotting software package
(plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux
Links project (loll.sf.net); and the Linux Brochure Project
(lbproject.sf.net).
__________________________

Linux-powered Science
__________________________