Re: [Plplot-devel] Incorrect pkg-config link flags with plplot 5.11.0

[Alan W. I. <ir...@be...>]

On 2015-04-25 09:59-0600 Orion Poplawski wrote:

> On 04/24/2015 07:58 PM, Alan W. Irwin wrote:
>> On 2015-04-24 10:09-0600 Orion Poplawski wrote:
[...]
>>> Libs: -L${libdir} -lplplotd
>> 
>> I don't get that at all for 5.10.0.
>
> Ah, mea culpa, we had:
>
> # Fix pkgconfig libs
> # https://bugzilla.redhat.com/show_bug.cgi?id=998988
> Patch4:         plplot-pkgconfig.patch
>
> diff -up plplot-5.9.9-svn12479/src/CMakeLists.txt.pkgconfig 
> plplot-5.9.9-svn12479/src/CMakeLists.txt
> --- plplot-5.9.9-svn12479/src/CMakeLists.txt.pkgconfig  2013-07-09 
> 13:27:35.000000000 -0600
> +++ plplot-5.9.9-svn12479/src/CMakeLists.txt    2013-08-23 10:17:31.522913437 
> -0600
> @@ -472,7 +472,9 @@ if(PKG_CONFIG_EXECUTABLE)
>   string(REGEX REPLACE "^.*:(.*):.*:.*$" "\\1" PC_SHORT_NAME ${PC_DATA})
>   string(REGEX REPLACE "^.*:.*:(.*):.*$" "\\1" PC_LONG_NAME ${PC_DATA})
>   string(REGEX REPLACE "^.*:.*:.*:(.*)$" "\\1" PC_LIBRARY_NAME ${PC_DATA})
> -  set(PC_LINK_FLAGS "${lib${PC_LIBRARY_NAME}_LINK_FLAGS}")
> +  if(NOT BUILD_SHARED_LIBS)
> +    set(PC_LINK_FLAGS "${lib${PC_LIBRARY_NAME}_LINK_FLAGS}")
> +  endif(NOT BUILD_SHARED_LIBS)
>   set(PC_LINK_FLAGS "-l${PC_LIBRARY_NAME} ${PC_LINK_FLAGS}")
>   set(PC_COMPILE_FLAGS "${lib${PC_LIBRARY_NAME}_COMPILE_FLAGS}")
>   set(PC_CONFIGURED_FILE

Thanks for figuring that out.

Of course, once I get the general shared versus static linking issue
for PLplot pkg-config results fixed upstream, that downstream patch
will no longer be necessary.

While we are at it, are there any other general issues like this one
(i.e., issues likely to affect all distros) addressed by the Fedora
downstream patches which we should be aware of upstream?

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________