Re: [Plplot-general] continuation lines in bindings/tcl/plplot_parameters.h

[Arjen M. <Arj...@de...>]

Hi Irena,



That is rather odd, the code is correct as far as I can tell. Could you try to compile this code:



module dummy

    interface plsvect

        module procedure plsvect1

        subroutine plsvect2

        end subroutine plsvect2

    end interface

contains

subroutine plsvect1( x )

   real :: x

end subroutine plsvect1

end module dummy




This should be perfectly acceptable code. If not, the PG compiler is doing something odd. Can you use a flag that will tell us more about what is wrong according to the compiler?

Regards,

Arjen


From: Irena Johnson [mailto:ijo...@pp...]
Sent: Wednesday, August 27, 2014 2:43 PM
To: Alan W. Irwin
Cc: plp...@li...
Subject: Re: [Plplot-general] continuation lines in bindings/tcl/plplot_parameters.h

Hi Alan, plplot_parameters.h

Thank you for your help with this issue: I got the latest version of plplot from git and your modification to plplot_parameters.h has worked!!

Unfortunately, the compiler now fails with "PGF90-S-0070-Incorrect sequence of statements"


[ 24%] Built target plplotf95c
Scanning dependencies of target plplotf95
[ 25%] Building Fortran object bindings/f95/CMakeFiles/plplotf95.dir/strutil.f90.o
[ 25%] Building Fortran object bindings/f95/CMakeFiles/plplotf95.dir/sfstubsf95.f90.o
PGF90-S-0070-Incorrect sequence of statements  (/pfs/tmp/ijohnson/plplot.git/bindings/f95/sfstubsf95.f90: 905)
  0 inform,   0 warnings,   1 severes, 0 fatal for plplot
make[3]: *** [bindings/f95/CMakeFiles/plplotf95.dir/sfstubsf95.f90.o] Error 2
make[2]: *** [bindings/f95/CMakeFiles/plplotf95.dir/sfstubsf95.f90.o.provides] Error 2
make[1]: *** [bindings/f95/CMakeFiles/plplotf95.dir/all] Error 2
make: *** [all] Error 2

Thank you,
--Irena

On Tue, Aug 26, 2014 at 7:00 PM, Alan W. Irwin <ir...@be...<mailto:ir...@be...>> wrote:
On 2014-08-26 13:21-0700 Alan W. Irwin wrote:
Getting back to the principal issue, it appears to me that gcc is
accepting all those "\n\" continuation lines in
bindings/tcl/plplot_parameters.h, but your Portland Group compiler is
not.  We will look further at this.

Hi Irena:

I have now changed the style of plplot_parameters.h to replace one huge string
literal by a large number of small string literals that the compiler
should automatically concatenate together.

I prefer this new style on general principles, and gcc compiles this
style just as well as the old style. It's possible your Portland Group
compiler will still choke on this style as it attempts to concatenate
those string literals together. But on the other hand, it might work.

To test that possibility, please try the latest version of our
source code using

git clone git://git.code.sf.net/p/plplot/plplot<http://git.code.sf.net/p/plplot/plplot> plplot.git

Then try your normal build (with -DENABLE_tcl=ON or else by removing
-DENABLE_tcl=OFF from the cmake command line since ENABLE_tcl is ON by
default) referring to this version of the source tree rather than
5.10.0 and starting from an empty build tree. If your compiler is
able to compile bindings/tcl/tclAPI.c without issues, then the change in style
should be judged a success.

Furthermore, I hope your set of Portland Group compilers is able to
finish the rest of a default build of PLplot without issues, but if
there are such issues we will try to deal with them since we prefer to
have PLplot builds be successful on all compilers and not just gcc.

By the way, I think the above is the first reference to our new
official git repository on this list (although there has been a large
amount of traffic about this huge change in PLplot development on the
plplot-devel list).  The short story is our svn repository at SF is
now frozen in read-only mode and as of a few days ago we switched to
using git for PLplot development with the above being our official git
repo.  I am pretty much a git newbie myself, but my use of it for the
last several days shows it is an extremely popular version control
system for good reasons.  Therefore, I think there is an excellent
chance this change from subversion to git will not only help our
current set of developers but also attract new developers to the
project.


Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca<http://astrowww.phys.uvic.ca>).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net<http://freeeos.sf.net>); the Time
Ephemerides project (timeephem.sf.net<http://timeephem.sf.net>); PLplot scientific plotting
software package (plplot.sf.net<http://plplot.sf.net>); the libLASi project
(unifont.org/lasi<http://unifont.org/lasi>); the Loads of Linux Links project (loll.sf.net<http://loll.sf.net>);
and the Linux Brochure Project (lbproject.sf.net<http://lbproject.sf.net>).
__________________________

Linux-powered Science
__________________________

DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.