From: Alan W. I. <ir...@be...> - 2013-10-20 05:10:05
|
On 2013-10-19 12:53-0700 Alan W. Irwin wrote: > Well, there are 74 such instances.... [in the make.out generated by MSVC]. It turned out that -O0 -Wuninitialized picked up those 74 issues as well (on Linux). So I fixed those (revision 12611). None of those were false alarms, but they all concerned the fail: path, i.e., whenever the python PLplot wrapper function was called with a bad argument, so potentially could have created extra real issues for that case. I have since discovered that -O3 -Wuninitialized shows additional issues in the bindings/python/plplotcmodulePYTHON_wrap.c file generated in the build tree by swig. These are less obvious to fix, but I plan to work on that first thing tomorrow (Sunday). All the above was tested with 64-bit Linux with no run-time issues when generating python results and no differences between those and the C results (which is expected since that has been the case for a while). I am holding off on testing anything on MinGW/MSYS/Wine until the Linux -O3 -Wuninitialized result is free of warnings for bindings/python/plplotcmodulePYTHON_wrap.c. Of course, I am not sure that any of this work will solve the python-C comparison issues for MinGW (and possibly gcc) on 32-bit systems, but I feel it is a good idea to systematically get rid of all "obvious" uninitialized warnings this way just in case one of them does affect that issue. I also fixed (I hope, since gcc does not warn about it) the following warning in your make.out file: D:\plplot-svn\plplot\drivers\ps.c(599) : warning C4244: 'initializing' : conversion from 'PLFLT' to 'int', possible loss of data What I did in that case was convert all the macros used for such comparisons to floating point numbers. (revision 12611). More tomorrow (Sunday). Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |