[Plplot-cvs] SF.net SVN: plplot:[11017] trunk/src/plcore.c

[<ai...@us...>]

Revision: 11017
          http://plplot.svn.sourceforge.net/plplot/?rev=11017&view=rev
Author:   airwin
Date:     2010-05-21 06:15:35 +0000 (Fri, 21 May 2010)

Log Message:
-----------
Implement an experimental solution for long-standing parallelogram
issue, but then comment it out because of other issues (strange aspect ratios
for integral -ori values; characters with incorrect aspect ratios, and
severe cropping issues) it causes.

Modified Paths:
--------------
    trunk/src/plcore.c

Modified: trunk/src/plcore.c
===================================================================
--- trunk/src/plcore.c	2010-05-21 06:12:23 UTC (rev 11016)
+++ trunk/src/plcore.c	2010-05-21 06:15:35 UTC (rev 11017)
@@ -1897,8 +1897,17 @@
     }
     calc_didev();
 
-/* Compute scale factors */
+    // Compute scale factors for relative device coordinates.  Only
+    // the aspect ratio of lx to ly matters.  Note, plsc->phyxlen and
+    // plsc->phyylen are in PLplot core library coordinates and don't
+    // know anything about device coordinates which are likely to have
+    // a quite different aspect ratio.  So to correct between the two
+    // coordinate systems must divide plsc->phyxlen/plsc->phyylen by
+    // plsc->aspori.
 
+    // N.B. comment out this correction because causes other issues.
+
+    //lx = plsc->phyxlen/plsc->aspori;
     lx = plsc->phyxlen;
     ly = plsc->phyylen;
 
@@ -2193,7 +2202,7 @@
         aspect_new       = plsc->aspect;
         plsc->caspfactor = sqrt( aspect_old / aspect_new );
     }
-/* Case of 90 deg rotations with -freeaspect (this is also how portraite
+/* Case of 90 deg rotations with -freeaspect (this is also how portrait
  * mode is implemented for the drivers that honor -portrait). */
     else if ( plsc->freeaspect && ABS( cos( plsc->diorot * PI / 2. ) ) <= 1.e-5 )
     {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.