[Plone-cvs] jenkins.plone.org/paranoid: Be paranoid and check every call to github

[Gil F. <je...@pl...>]

Repository: jenkins.plone.org
Branch: refs/heads/paranoid
Date: 2015-12-01T22:34:43+01:00
Author: Gil Forcada (gforcada) <gfo...@gn...>
Commit: https://github.com/plone/jenkins.plone.org/commit/ff9a36acc14da53cbe45c4598510554f4e348357

Be paranoid and check every call to github

It doubles as typos/errors reporting tool whenever someone makes a mistake
when creating a pull request job.

Files changed:
M scripts/pr-get-info.py

diff --git a/scripts/pr-get-info.py b/scripts/pr-get-info.py
index 97d238f..e134e0e 100644
--- a/scripts/pr-get-info.py
+++ b/scripts/pr-get-info.py
@@ -1,36 +1,133 @@
 # -*- coding: utf-8 -*-
+from github import Github
+from github.GithubException import BadCredentialsException
+from github.GithubException import UnknownObjectException
+
 import fileinput
-import json
 import os
 import re
 import sys
-import urllib2
 
-pull_request_urls = os.environ['PULL_REQUEST_URL']
 
 PKG_RE = r'^{0}\s.*'
 SOURCE_RE = r'{0} = git git://github.com/{1}/{0}.git branch={2}'
+PR_RE = r'https://github.com/(.*)/(.*)/pull/(.*)'
 
 PKGS = []
 COREDEV = 0
 
-for i, pr in enumerate(pull_request_urls.split()):
-    github_api_call = pr.replace('github.com', 'api.github.com/repos')
-    github_api_call = github_api_call.replace('/pull/', '/pulls/')
+try:
+    github_api_key = os.environ['GITHUB_API_KEY']
+except KeyError:
+    print(
+        '\n\n\n'
+        'GITHUB_API_KEY does not exist, pull request job can not run. '
+        '\n'
+        'Please contact the testing team: '
+        'https://github.com/orgs/plone/teams/testing-team'
+        '\n'
+        'Fill an issue as well: '
+        'https://github.com/plone/jenkins.plone.org/issues/new'
+        '\n\n\n'
+    )
+    sys.exit(1)
+
+try:
+    pull_request_urls = os.environ['PULL_REQUEST_URL']
+except KeyError:
+    print(
+        '\n\n\n'
+        'You seem to forgot to add a pull request URL on the '
+        '"Build with parameters" form!'
+        '\n\n\n'
+    )
+    sys.exit(1)
+
+build_url = os.environ['BUILD_URL']
+
+g = Github(github_api_key)
+
+for pr in pull_request_urls.split():
+    org, repo, pr_number = re.search(PR_RE, pr).groups()
+
+    try:
+        pr_number = int(pr_number)
+    except ValueError:
+        msg = (
+            '\n\n\n'
+            'Error on trying to get info from Pull Request %s'
+            '\n'
+            'The pull request number "%s" is not a number!'
+            '\n\n\n'
+        )
+        print(msg % (pr, pr_number))
+        sys.exit(1)
+
+    # get the pull request organization it belongs to
+    try:
+        g_org = g.get_organization(org)
+    except BadCredentialsException:
+        print(
+            '\n\n\n'
+            'The API key used seems to not be valid any longer.'
+            '\n'
+            'Please contact the testing team: '
+            'https://github.com/orgs/plone/teams/testing-team'
+            '\n'
+            'Fill an issue as well: '
+            'https://github.com/plone/jenkins.plone.org/issues/new'
+            '\n\n\n'
+        )
+        sys.exit(1)
+    except UnknownObjectException:
+        msg = (
+            '\n\n\n'
+            'Error on trying to get info from Pull Request %s'
+            '\n'
+            'The organization "%s" does not seem to exist.'
+            '\n\n\n'
+        )
+        print(msg % (pr, org))
+        sys.exit(1)
+
+    # the repo where the pull request is from
+    try:
+        g_repo = g_org.get_repo(repo)
+    except UnknownObjectException:
+        msg = (
+            '\n\n\n'
+            'Error on trying to get info from Pull Request %s'
+            '\n'
+            'The repository "%s" does not seem to exist.'
+            '\n\n\n'
+        )
+        print(msg % (pr, repo))
+        sys.exit(1)
 
-    response = urllib2.urlopen(github_api_call)
-    json_data = json.loads(response.read())
+    # the pull request itself
+    try:
+        g_pr = g_repo.get_pull(pr_number)
+    except UnknownObjectException:
+        msg = (
+            '\n\n\n'
+            'Error on trying to get info from Pull Request %s'
+            '\n'
+            'The pull request num "%s" does not seem to exist.'
+            '\n\n\n'
+        )
+        print(msg % (pr, pr_number))
+        sys.exit(1)
 
-    org, branch = json_data['head']['label'].split(':')
-    pkg = json_data['base']['repo']['name']
+    # get the branch
+    branch = g_pr.head.ref
 
-    if pkg != 'buildout.coredev':
-        PKGS.append(pkg)
+    if repo != 'buildout.coredev':
+        PKGS.append(repo)
         for line in fileinput.input('sources.cfg', inplace=True):
-            if line.find(pkg) != -1:
+            if line.find(repo) != -1:
                 line = re.sub(
-                    PKG_RE.format(pkg),
-                    SOURCE_RE.format(pkg, org, branch),
+                    PKG_RE.format(repo),
+                    SOURCE_RE.format(repo, org, branch),
                     line
                 )
             sys.stdout.write(line)