[Plone-cvs] r30083 - buildouts/plone-coredev/branches/4.0/plips

[Eric S. <svn...@pl...>]

Author: esteele
Date: Wed Sep 30 18:04:15 2009
New Revision: 30083

Modified:
   buildouts/plone-coredev/branches/4.0/plips/plip9315-review-esteele.txt
Log:
Adding merge review (+1 recommendation) for 9315. Refs #9315.

Modified: buildouts/plone-coredev/branches/4.0/plips/plip9315-review-esteele.txt
==============================================================================
--- buildouts/plone-coredev/branches/4.0/plips/plip9315-review-esteele.txt	(original)
+++ buildouts/plone-coredev/branches/4.0/plips/plip9315-review-esteele.txt	Wed Sep 30 18:04:15 2009
@@ -43,4 +43,19 @@
 to spend time picking at minor design details in this review.
 
 I like the design. I like the general idea behind the changes made. Consider
-me +1 on inclusion, assuming it's finished at some point.
\ No newline at end of file
+me +1 on inclusion, assuming it's finished at some point.
+
+
+Merge Review
+------------
+
+About 52K lighter (unmerged) than the current plone theme.
+
+Plays nicely with the existing ("classic") theme. The two flip back and forth
+without issue in the Themes prefs panel.
+
+Backed off on HTML5, which, for no good reason, makes me a bit more comfortable.
+
+Still lots of little details to be worked out, but in all: it's a theme, and
+one by Limi at that, it was destined to be a work in progress. It's a good
+design, well implemented. Recommend +1 for merge.