Menu

#51 Don't use rmtree to delete deleted elements.

open
nobody
None
5
2010-11-29
2010-11-29
No

PlominoDesignManager.exportDesign should compare current exported files with existing ones, and delete ones that have gone away.
It should not use rmtree, because the exported folder may be under version control, and this would nuke the .svn directory.

Discussion

  • Eric Brehault

    Eric Brehault - 2010-11-29

    oh!
    right
    of course, sorry, I missed that point

    if we remove only *.xml, it should be ok, what do you think ?

     
  • Jean Jordaan

    Jean Jordaan - 2010-11-29

    Yes, the only thing better would probably be to start using a MANIFEST file which enumerates the interesting files. But *.xml is good enough I think.

     
  • Eric Brehault

    Eric Brehault - 2010-11-29

    fixed in svn 1109

     

Log in to post a comment.

MongoDB Logo MongoDB