Re: [Plib-devel] PUI crash in Tuxkart.

[Sam S. <sa...@sp...>]

----- Original Message -----
From: "Steve Baker" <sjb...@ai...>
To: <pli...@li...>
Sent: Tuesday, October 03, 2000 12:44 AM
Subject: Re: [Plib-devel] PUI crash in Tuxkart.


> Ben Woodhead wrote:
> >
> > Confess, never. Just kidding, I had a chance to look at this and
> > puOneShot.cxx has not been changed since feb, so Its not that, the pu.h file
> > has been changed alot, but I can't find any changes to the class
> > declarations. The only thing is the diff between 1.15 and 1.14, puOneShot
> > comes up in that list but they seem to be the same, almost as if the spacing
> > was changed or something like that.
>
> I don't think the bug is in puOneShot - the data seems to be corrupted before
> it every gets into that code...something higher up (puGroup perhaps) is suspect.
>
> I'll try to find time to dig deeper.

Well if it's puGroup there hasn't been many changes to that in it's cvs lifetime.  Here's the report from CVS:

Rcs file : '/cvsroot/plib/plib/src/pui/puGroup.cxx,v'
Working file : 'puGroup.cxx'
Head revision : 1.3
Branch revision :
Locks : strict
Access :
Symbolic names :
1.1.1.1 : 'start'
1.1.1 : 'vendor'
Keyword substitution : 'kv'
Total revisions : 4
Selected revisions : 4
Description :

----------------------------
Revision : 1.3
Date : 2000/9/27 15:30:48
Author : 'zander76'
State : 'Exp'
Lines : +3 0
Description :
Added Active Widget Implementation
----------------------------
Revision : 1.2
Date : 2000/8/2 20:3:29
Author : 'mcdave'
State : 'Exp'
Lines : +6 -2
Description :
fixed bug in destructor
----------------------------
Revision : 1.1
Date : 2000/2/1 5:56:40
Author : 'sjbaker'
State : 'Exp'
Lines : +0 0
Branches :
1.1.1
Description :
Initial revision
----------------------------
Revision : 1.1.1.1
Date : 2000/2/1 5:56:40
Author : 'sjbaker'
State : 'Exp'
Lines : +0 0
Description :
First Added PLIB to CVS archive on sourceforge.
===============================================

So, in puGroup at least, the only thing that recently changed is the addition of active widgets.  Perhaps someone could check out
plib 26th September (the day before the addition) and see if the crash still exists with that code?

Hmm.. actually a CVS diff between 1.2 and 1.3 shows that:

puGroup::~puGroup ()
{
  for ( puObject *bo = dlist ; bo != NULL ; /* Nothing */ )
  {
    dlist = bo    ;
    bo = bo->next ;
    delete dlist  ;
  }
}

became:

puGroup::~puGroup ()
{
  for ( puObject *bo = dlist ; bo != NULL ; /* Nothing */ )
  {
    dlist = bo    ;
    bo = bo->next ;
    delete dlist  ;
  }

  if ( this == puActiveWidget () )
    puDeactivateWidget () ;
}

and that's it.  Hardly a great change...  So there are probably issues elsewhere as well.  Here's a list of all the files that got
changed in the active widget stuff - I think this was the last big change to PUI.  Someone who know PUI a bit better will have to
dig through this list and see which files are likely to be the culprit.


===============================================
Working file : 'puSlider.cxx'
Revision : 1.3
Lines : +9 0
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'puPopupMenu.cxx'
Revision : 1.4
Lines : +7 -1
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'puObject.cxx'
Revision : 1.3
Lines : +18 0
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'puListBox.cxx'
Revision : 1.3
Lines : +7 0
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'puInterface.cxx'
Revision : 1.3
Lines : +3 0
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'puInput.cxx'
Revision : 1.3
Lines : +14 0
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'puGroup.cxx'
Revision : 1.3
Lines : +3 0
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'puFilePicker.cxx'
Revision : 1.6
Lines : +3 0
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'puButtonBox.cxx'
Revision : 1.3
Lines : +14 0
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'puButton.cxx'
Revision : 1.3
Lines : +7 0
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'puBiSlider.cxx'
Revision : 1.2
Lines : +9 0
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'pu.h'
Revision : 1.14
Lines : +27 -10
Description :
Added Active Widget Implementation
===============================================

===============================================
Working file : 'pu.cxx'
Revision : 1.11
Lines : +23 -13
Description :
Added Active Widget Implementation
===============================================

Sam