From: Marcos V. <mv...@us...> - 2007-08-27 22:50:24
|
There is a mistake on the Create driver. At file /player-2.0.4/server/drivers/mixed/irobot/create/create_comms.c the function create_parse_sensor_packet() at line 403 should be angle = DTOR(signed_int); instead of angle = (2.0 * (signed_int / 1e3)) / CREATE_AXLE_LENGTH; because Create already returns the angle in degrees. Just check the manual. Sometimes, we shouldn't just copy and paste code. The Create Manual: http://www.irobot.com/filelibrary/create/Create%20Open%20Interface_v2.pdf Roomba Manual: http://www.irobot.com/images/consumer/hacker/Roomba_SCI_Spec_Manual.pdf Thanks, Marcos |
From: Nate K. <nk...@us...> - 2007-08-30 16:05:24
|
Hello Marcos, Thanks for the fix. > Sometimes, we shouldn't just copy and paste code. This is an open source community, with a stress on community. We appreciate you debugging the code, but you shouldn't berate other developers. That doesn't build a better community. -nate On 8/27/07, Marcos Vieira <mv...@us...> wrote: > There is a mistake on the Create driver. At file > /player-2.0.4/server/drivers/mixed/irobot/create/create_comms.c > the function create_parse_sensor_packet() at line 403 > should be > > angle = DTOR(signed_int); > > instead of > angle = (2.0 * (signed_int / 1e3)) / CREATE_AXLE_LENGTH; > > because Create already returns the angle in degrees. Just check the manual. > Sometimes, we shouldn't just copy and paste code. > > The Create Manual: > http://www.irobot.com/filelibrary/create/Create%20Open%20Interface_v2.pdf > > Roomba Manual: > http://www.irobot.com/images/consumer/hacker/Roomba_SCI_Spec_Manual.pdf > > Thanks, > Marcos > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > Playerstage-developers mailing list > Pla...@li... > https://lists.sourceforge.net/lists/listinfo/playerstage-developers > |
From: Marcos V. <mv...@us...> - 2007-08-30 16:25:28
|
Sorry, I did not mean to berate developers. Of course I agree with the open source community philosophy, that is why I posted here. I hope you can add this fix to next player release. Thanks, Marcos ----- Original Message ----- From: Nate Koenig <nk...@us...> Date: Thursday, August 30, 2007 9:05 am Subject: Re: [Playerstage-developers] Create Driver Bug > Hello Marcos, > > Thanks for the fix. > > > Sometimes, we shouldn't just copy and paste code. > > This is an open source community, with a stress on community. We > appreciate you debugging the code, but you shouldn't berate other > developers. That doesn't build a better community. > > -nate > > On 8/27/07, Marcos Vieira <mv...@us...> wrote: > > There is a mistake on the Create driver. At file > > /player-2.0.4/server/drivers/mixed/irobot/create/create_comms.c > > the function create_parse_sensor_packet() at line 403 > > should be > > > > angle = DTOR(signed_int); > > > > instead of > > angle = (2.0 * (signed_int / 1e3)) / CREATE_AXLE_LENGTH; > > > > because Create already returns the angle in degrees. Just check > the manual. > > Sometimes, we shouldn't just copy and paste code. > > > > The Create Manual: > > > http://www.irobot.com/filelibrary/create/Create%20Open%20Interface_v2.pdf> > > Roomba Manual: > > > http://www.irobot.com/images/consumer/hacker/Roomba_SCI_Spec_Manual.pdf> > > Thanks, > > Marcos > > > > ------------------------------------------------------------------ > ------- > > This SF.net email is sponsored by: Splunk Inc. > > Still grepping through log files to find problems? Stop. > > Now Search log events and configuration files using AJAX and a > browser.> Download your FREE copy of Splunk now >> > http://get.splunk.com/> > _______________________________________________> Playerstage- > developers mailing list > > Pla...@li... > > https://lists.sourceforge.net/lists/listinfo/playerstage-developers > > > > -------------------------------------------------------------------- > ----- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a > browser.Download your FREE copy of Splunk now >> > http://get.splunk.com/_______________________________________________ > Playerstage-developers mailing list > Pla...@li... > https://lists.sourceforge.net/lists/listinfo/playerstage-developers > |