From: Brian G. <br...@ge...> - 2007-04-24 22:13:43
|
hi, I'm ready to release Player 2.0.4, which will include a bunch of bugfixes, as well as many enhancements. In general, non-interface- breaking changes to HEAD have been merged to the 2.0.x branch. I'll do the release in the next few days, perhaps Friday. In the meantime, please test if you can, and let me know if there's something in particular that should be included in 2.0.4. The release will come from the 2.0.x branch, which you can check out like so: $ cvs co -r release-2-0-patches player brian. |
From: Jack O'Q. <jac...@gm...> - 2007-04-25 02:09:05
|
On 4/24/07, Brian Gerkey <br...@ge...> wrote: > hi, > > I'm ready to release Player 2.0.4, which will include a bunch of > bugfixes, as well as many enhancements. In general, non-interface- > breaking changes to HEAD have been merged to the 2.0.x branch. > > I'll do the release in the next few days, perhaps Friday. In the > meantime, please test if you can, and let me know if there's > something in particular that should be included in 2.0.4. Here is a patch Patrick Beeson sent you a few weeks ago, which seems to be necessary for player commands to honor replace mode. We have been using it for a while, and it fixes some rather severe queue overflow problems we had been seeing. As far as we can tell, this was the original intent of the replace mode design. There is a similar test in CheckReplace(), but it only affects the default replacement rule. --- ../../player/cvs-20070404/libplayercore/message.cc 2007-04-10 21:20:19.000000000 -0500 +++ libplayercore/message.cc 2007-04-10 21:16:19.000000000 -0500 @@ -390,7 +390,10 @@ { MessageQueueElement* newelt = new MessageQueueElement(); newelt->msg = new Message(msg); - if (!pull || newelt->msg->GetHeader ()->type != PLAYER_MSGTYPE_DATA) + if (!pull || (newelt->msg->GetHeader ()->type != PLAYER_MSGTYPE_DATA && + // Pat Beeson: Need next line to be able to replace + // Commands in message queue + newelt->msg->GetHeader ()->type != PLAYER_MSGTYPE_CMD)) { // If not in pull mode, or message is not data, set ready to true immediatly newelt->msg->SetReady (); -- joq |
From: Sidney C. <sid...@ji...> - 2007-04-26 05:31:44
|
Hi Brian, > I'll do the release in the next few days, perhaps Friday. In the > meantime, please test if you can, and let me know if there's > something in particular that should be included in 2.0.4. I think it would be a good idea to patch for issue #1697382: http://sourceforge.net/tracker/index.php?func=detail&aid=1697382&group_id=42 445&atid=433166 It would be rather unhelpful to have a point release that fails to build on many systems. I will upload an improved patch for this issue within the next couple of hours. Best regards, Sidney |
From: Sidney C. <sid...@ji...> - 2007-04-26 06:19:17
|
> I will upload an improved patch for this issue within the next couple of hours. Done. Please consider this patch for inclusion in 2.0.4. Best regards, Sidney |