Re: [Pkgutil-users] comparing multiple versions without revisions fails - patch attached for review
Status: Beta
Brought to you by:
bonivart
|
From: KillBoy P. <kil...@ya...> - 2013-08-22 02:25:29
|
Hi Peter, The internal packaging system has been around a longer than me so getting all the app builds updated to include revision info is not likely to happen without someone coughing up some cash, I guess they'll have to stick with this fix or specify the required version in puppet rather than 'latest' thanks ________________________________ From: Peter Bonivart <bon...@op...> To: KillBoy PowerHed <kil...@ya...>; pkgutil-users <pkg...@li...> Sent: Wednesday, 21 August 2013 5:13 PM Subject: Re: [Pkgutil-users] comparing multiple versions without revisions fails - patch attached for review On Tue, Aug 20, 2013 at 5:19 PM, Peter Bonivart <bon...@op...> wrote: > On Tue, Aug 20, 2013 at 5:01 AM, KillBoy PowerHed > <kil...@ya...> wrote: >> Hi list, >> >> I came across this issue yesterday when I found "ensure => 'latest'" had >> never worked in puppet with custom package repositories, it seems to be the >> 4th case in verscmp() that was the culprit. I've stolen versioncmp() from >> the Sort::Versions CPAN module and call that inside case 4 now which seems >> to be working. >> >> This patch seems a little hacky and could obviously do with some thorough >> testing and more eyes so if you have this issue please take a look at the >> attached, hopefully someone can come up with a cleaner solution. >> >> thanks > > Since it's impossible to cover all variants of versions OpenCSW > intentionally choose to ignore the upstream version and only use the > REV-field which is purely numeric, this is documented here: > http://pkgutil.wikidot.com/get-install-and-configure#toc9. > > I have always recommended people who create their own repos to follow > that standard and they will get it right every time. Example: > 1.0,REV=2013.08.20 but any number of numeric fields are supported, > e.g. 1.0,REV=1234 or 1.0,REV=2013.08.20.17.16. Just remembered that there's more documentation here about this: http://pkgutil.wikidot.com/bldcat#toc2. /peter |