#285 15.1 Development card handling

[Roland Clobus]

Reported by Bas wijnen on pio-develop:
The development card handling in 15.1 is not correct.

I have been able to reproduce the situation:
- Apply the attached patch to 15.1 (it fixes the first 5 development cards)
- Use the admin-interface to be able to buy 5 development cards in one turn
- Wait for the next turn
- Select the Chapel entry, and press Play Card. The third card will be a Soldier.

Note: this patch is not to be committed to svn.

[Roland Clobus]

I've reproduced the bug with:
- Server = 15.1, Client = 15.1
- Server = 15.1, Client = 14.1
- Server = 14.1, Client = 14.1

[Roland Clobus]

The bug occurs only when the selection is unchanged:
- Set the selection on Chapel, press 3x Play Card -> Bug
- Set the selection on Chapel, press 2x Play Card, set selection to Soldier, then to Chapel, press Play Card -> No bug

So the bug is in client/gtk/develop.c. Probably introduced by me...

[Roland Clobus]

A fix was added to svn 2036 (Pioneers 15.2)

[Bas Wijnen]

This bug is still present in 15.3.

[Roland Clobus]

Reopening this ticket.

Also noted by Laura Fuller 2015-01-15T10:13:

I confirm that the Ubuntu build of 15.4 has the same problem. I have a

market card from turn T. On turn T+1 I get a year of plenty. So I can't

(turn T+1) play year of plenty. But I can play the market card. But I

don't. I move to the next turn: T+2. I should be able to play any of the

development cards. And I can. I play market. I am left with Road

building on turn T+2. I move forward. Turn T+3. I have Road building in

my hand and I can't play it. Unless I buy another development card. I

get year of plenty. I can't play year of plenty this turn because I just

bought it. But I can change the selection and now I can play road

building after the selection change. I can't tell how things develop

as I win the game.

[Roland Clobus]

This should be fixed in r2124 (Pioneers 15.4)

When the selection in the combobox changes to another development card type because the currently selected development card is not available any more, correctly update the 'Play Development Card' button status

[Roland Clobus]

Pioneers 15.4 has been release some time ago. Closing this ticket.