Menu
▾
▴
pidgin-patches — Updates to the Gaim patches tracker
You can subscribe to this list here.
| 2004 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(435) |
Dec
(252) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2005 |
Jan
(177) |
Feb
(157) |
Mar
(187) |
Apr
(168) |
May
(127) |
Jun
(291) |
Jul
(38) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: SourceForge.net <no...@so...> - 2005-03-12 01:07:27
|
Patches item #1161777, was opened at 2005-03-12 01:07 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1161777&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Hassan (mickeynoear) Assigned to: Nobody/Anonymous (nobody) Summary: Truncate Long Friendly Name Initial Comment: Probably this will get moved to 'Rejected Patches' section. But I'll send it here for review anyway. Changed function gaim_gtk_blist_get_name_markup in gtkblist.c so that it will truncate long friendly names in the buddy list. The truncate length is determined by an option in the preference window Changed function max_name_enter_callback in gtkprefs.c to add a textbox and labels where the user can specify the maximum length of friendly name before starting to truncate it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1161777&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-12 00:55:57
|
Patches item #1161774, was opened at 2005-03-12 00:55 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1161774&group_id=235 Category: newfeature Group: None Status: Open Resolution: None Priority: 5 Submitted By: Hassan (mickeynoear) Assigned to: Nobody/Anonymous (nobody) Summary: Change Buddy Icon in Conversation window Initial Comment: I have seen many requests for this. Stolen from gtkaccount.c shamelessly: - icon_select_cb and related callbacks wich are part of the fileselector 'add/modify account' dialog. modified in gtkconv.c : - added a 'Change Buddy Icon..' under the menu Options, which triggers icon_select_cb This patch also includes an appearance change in the Conversation Window menu. The changes are: - moved menu items from Conversation menu list that are related to contacts into a separate menu list ( named Contact ). - moved menu items from Conversation menu list that are related to history into a separate menu list ( named Contact ). -shuffled menu items according to their group, like: original : Alias, Block, Remove modified to : Warn, Block, Remove original: Send File, Add Buddy Pounce, Get Info, Warn modified to : Alias, Get Info, Add Buddy Pounce The changes were done according to my opinion/preference. Take a look and abandon the idea if it looks ugly =P. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1161774&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-11 13:06:02
|
Patches item #1161128, was opened at 2005-03-11 00:07 Message generated for change (Settings changed) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1161128&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Gary Kramlich (amc_grim) Assigned to: Luke Schierer (lschiere) Summary: long awaited cipher api... Initial Comment: luke and ethan know what this is.. possible more.. ---------------------------------------------------------------------- >Comment By: Luke Schierer (lschiere) Date: 2005-03-11 08:05 Message: Logged In: YES user_id=28833 and it is in! ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-03-11 07:49 Message: Logged In: YES user_id=28833 yay!! congratulations on finishing a tremendous endevour grim! its building now. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1161128&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-11 12:50:01
|
Patches item #1161128, was opened at 2005-03-11 00:07 Message generated for change (Comment added) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1161128&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Gary Kramlich (amc_grim) >Assigned to: Luke Schierer (lschiere) Summary: long awaited cipher api... Initial Comment: luke and ethan know what this is.. possible more.. ---------------------------------------------------------------------- >Comment By: Luke Schierer (lschiere) Date: 2005-03-11 07:49 Message: Logged In: YES user_id=28833 yay!! congratulations on finishing a tremendous endevour grim! its building now. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1161128&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-11 05:07:51
|
Patches item #1161128, was opened at 2005-03-10 23:07 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1161128&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Gary Kramlich (amc_grim) Assigned to: Nobody/Anonymous (nobody) Summary: long awaited cipher api... Initial Comment: luke and ethan know what this is.. possible more.. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1161128&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-11 00:32:47
|
Patches item #1144306, was opened at 2005-02-19 06:17 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1144306&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Etan Reisner (deryni9) Summary: file xfer signals Initial Comment: hello. this patch introduces some signals for plugins that wish to handle file xfers ( yeah.. i am writing one such plugin :p ). signals for xfer start/accept/cancel/done are registered and emitted. -- Adil ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-03-10 19:32 Message: Logged In: YES user_id=20979 Hmm, I get the feeling this is going to needlessly clutter things. Would it make more sense for you to call gaim_xfers_set_ui_ops() with your own UI callback functions? ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-02-24 05:56 Message: Logged In: YES user_id=1132702 made some changes (moves the init and uninit from gtkmain.c to core.c).. and the diff is against the cvs -- Adil ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-02-20 02:59 Message: Logged In: YES user_id=1132702 duh... forgot that checkbox for attachment :blush: -- Adil ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1144306&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-10 23:47:41
|
Patches item #1159244, was opened at 2005-03-08 13:16 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159244&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) >Assigned to: Mark Doliner (thekingant) Summary: Fix Compiler Warning in gtkutils.c Initial Comment: This fixes some compiler warnings in gtkutils.c that occur when using glib 2.6.x. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-03-10 18:47 Message: Logged In: YES user_id=20979 Word. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159244&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-10 23:44:30
|
Patches item #1159278, was opened at 2005-03-08 13:45 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159278&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) >Assigned to: Mark Doliner (thekingant) Summary: Logging Code Duplication Fix Initial Comment: As I was looking at this function because of a valgrind error Stu was getting, I saw that this code is duplicated. To make it more clear what's happening here, I'm submitting this patch to eliminate the duplication. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-03-10 18:44 Message: Logged In: YES user_id=20979 Thanks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159278&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-09 19:09:55
|
Patches item #1160119, was opened at 2005-03-09 20:09 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1160119&group_id=235 Category: newfeature Group: None Status: Open Resolution: None Priority: 5 Submitted By: madman (madman_bg) Assigned to: Nobody/Anonymous (nobody) Summary: option to hide login dialog Initial Comment: Hi! I've got an enhancement proposal. Gaim could have, as an option, a feature for hiding login window. It's annoying that gaim pops up a window, ie. while starting or on reconnect. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1160119&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-09 17:59:14
|
Rejected Patches item #1160067, was opened at 2005-03-09 17:59 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=700058&aid=1160067&group_id=235 Category: None Group: None Status: Open Priority: 5 Submitted By: Hassan (mickeynoear) Assigned to: Nobody/Anonymous (nobody) Summary: Modified Conversation Window Initial Comment: I tweaked the menubars in the conversation window to my liking. I think it looks better this way. I added a menu item 'Change buddy icon' under Options but it's greyed until somebody will be kind enough to implement the callbacks and stuffs. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=700058&aid=1160067&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-09 02:12:50
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 13:12 Message: Logged In: YES user_id=407708 Ok, here's an initial 1.x patch. Comments welcome. I've done *some* tidying up. More comments welcome. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 11:02 Message: Logged In: YES user_id=407708 There's one more 'thing' I'd like to get in here, for ease of chat UI use. Give me a few hours. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 12:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-08 11:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-09 00:13:04
|
Patches item #1159246, was opened at 2005-03-08 13:20 Message generated for change (Comment added) made by deryni9 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159246&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Sean Egan (seanegan) Summary: Raise on Events Pref Slashing Typo Initial Comment: As I was debugging something completely unrelated, I saw an assertion notice. I tracked it down to this pref. I'm figuring this is a simple typo that occurred during the pref-slash. ---------------------------------------------------------------------- >Comment By: Etan Reisner (deryni9) Date: 2005-03-08 19:13 Message: Logged In: YES user_id=516184 You're a bit insane, you know that? Thanks again. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159246&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-09 00:04:04
|
Patches item #1159245, was opened at 2005-03-08 13:18 Message generated for change (Comment added) made by deryni9 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159245&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Etan Reisner (deryni9) Summary: Fix GAIM_VERSION_CHECK Syntax Error Initial Comment: GAIM_VERSION_CHECK has a syntax error. I looked in ViewCVS and it appears to have been broken for some time. It wasn't always broken though. ---------------------------------------------------------------------- >Comment By: Etan Reisner (deryni9) Date: 2005-03-08 19:04 Message: Logged In: YES user_id=516184 Good catch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159245&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-09 00:02:14
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-09 11:02 Message: Logged In: YES user_id=407708 There's one more 'thing' I'd like to get in here, for ease of chat UI use. Give me a few hours. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 12:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-08 11:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-08 18:45:37
|
Patches item #1159246, was opened at 2005-03-08 13:20 Message generated for change (Settings changed) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159246&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) >Assigned to: Sean Egan (seanegan) Summary: Raise on Events Pref Slashing Typo Initial Comment: As I was debugging something completely unrelated, I saw an assertion notice. I tracked it down to this pref. I'm figuring this is a simple typo that occurred during the pref-slash. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159246&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-08 18:45:25
|
Patches item #1159245, was opened at 2005-03-08 13:18 Message generated for change (Settings changed) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159245&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) >Assigned to: Etan Reisner (deryni9) Summary: Fix GAIM_VERSION_CHECK Syntax Error Initial Comment: GAIM_VERSION_CHECK has a syntax error. I looked in ViewCVS and it appears to have been broken for some time. It wasn't always broken though. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159245&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-08 18:45:15
|
Patches item #1159244, was opened at 2005-03-08 13:16 Message generated for change (Settings changed) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159244&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) >Assigned to: Sean Egan (seanegan) Summary: Fix Compiler Warning in gtkutils.c Initial Comment: This fixes some compiler warnings in gtkutils.c that occur when using glib 2.6.x. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159244&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-08 18:45:01
|
Patches item #1159278, was opened at 2005-03-08 12:45 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159278&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Logging Code Duplication Fix Initial Comment: As I was looking at this function because of a valgrind error Stu was getting, I saw that this code is duplicated. To make it more clear what's happening here, I'm submitting this patch to eliminate the duplication. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159278&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-08 18:20:37
|
Patches item #1159246, was opened at 2005-03-08 12:20 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159246&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Raise on Events Pref Slashing Typo Initial Comment: As I was debugging something completely unrelated, I saw an assertion notice. I tracked it down to this pref. I'm figuring this is a simple typo that occurred during the pref-slash. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159246&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-08 18:18:25
|
Patches item #1159245, was opened at 2005-03-08 12:18 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159245&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Fix GAIM_VERSION_CHECK Syntax Error Initial Comment: GAIM_VERSION_CHECK has a syntax error. I looked in ViewCVS and it appears to have been broken for some time. It wasn't always broken though. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159245&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-08 18:16:25
|
Patches item #1159244, was opened at 2005-03-08 12:16 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159244&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Fix Compiler Warning in gtkutils.c Initial Comment: This fixes some compiler warnings in gtkutils.c that occur when using glib 2.6.x. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1159244&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-08 16:40:45
|
Patches item #982227, was opened at 2004-06-29 15:13 Message generated for change (Comment added) made by charkins You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=982227&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Casey Harkins (charkins) Assigned to: Sean Egan (seanegan) Summary: docklet: play message received sound when message is waiting Initial Comment: This patch to the system tray plugin adds a preference option to play the message received sound when a message is waiting. The sound is played when the status changes to online_pending. ---------------------------------------------------------------------- >Comment By: Casey Harkins (charkins) Date: 2005-03-08 10:40 Message: Logged In: YES user_id=254876 For the record, I think the correct approach to fixing this and potentially other sound issues is to move all existing gaim sound code into a plugin. Sound events already occur is situations where a signal is being emitted. Using a plugin would allow the sounds to be de-coupled from the interface (the problem in this particular case). It should also simplify the codebase as sound support would be entirely self contained within a plugin instead of littered throughout the core components. I had started work on this a few months ago, but haven't found time to finish it up. I was planning on working on this again soon, unless someone beats me to it. Anyone agree or disagree with moving all sound support into a plugin? ---------------------------------------------------------------------- Comment By: Casey Harkins (charkins) Date: 2004-08-20 15:48 Message: Logged In: YES user_id=254876 I'm not sure that this patch uses the right approach. The correct way to handle this would be for gaim to play sounds for received messages as they are received, rather than when the window is open. This patch just adds an extra sound that plays when the docklet icon changes status (to online_pending). If I get a chance, I'll take a look at implementing this correctly. ---------------------------------------------------------------------- Comment By: Casey Harkins (charkins) Date: 2004-06-29 15:25 Message: Logged In: YES user_id=254876 This cooresponds to RFE #966977 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=982227&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-08 03:16:18
|
Patches item #1115963, was opened at 2005-02-04 00:07 Message generated for change (Settings changed) made by datallah You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1115963&group_id=235 Category: win32 Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Daniel Atallah (datallah) Summary: Windows Special Folders Initial Comment: This patch creates a new function to obtain the paths to special folders on Windows. It also modifies the single existing instance of this to use the new function. I'm submitting this because I'm submitting another patch which depends on it. Also, my log reader plugin will depend on this new function. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-02-25 20:17 Message: Logged In: YES user_id=156487 Posting a new version. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-02-18 01:07 Message: Logged In: YES user_id=156487 Daniel committed changes which conflict with this patch. I'll post a new version as soon as I can figure out why Gaim refuses to link for me in Windows. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1115963&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-08 03:15:51
|
Patches item #1115968, was opened at 2005-02-04 00:10 Message generated for change (Settings changed) made by datallah You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1115968&group_id=235 Category: win32 Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Daniel Atallah (datallah) Summary: Windows File Chooser Default Folders Initial Comment: Depends on Patch #1115963 The default path in the file chooser on Windows is very bizarre. It's a folder in the GTK directory. This patch selects sensible defaults. ---------------------------------------------------------------------- Comment By: Daniel Atallah (datallah) Date: 2005-03-02 22:49 Message: Logged In: YES user_id=325843 A few observations: my_received_files is never g_free'd. We can't assume that users will be running the english language version of windows ("My Received Files"). Wouldn't it be enough to generate the default value for "/gaim/gtk/filelocations/last_open_folder" in this way, rather than having the lookup in this function. It seems to me that this problem is only ever going to happen the first time that the file chooser is opened, it should then remember the last directory, right? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-02-25 20:17 Message: Logged In: YES user_id=156487 Posting a new version. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-02-18 01:07 Message: Logged In: YES user_id=156487 Daniel committed changes which conflict with this patch. I'll post a new version as soon as I can figure out why Gaim refuses to link for me in Windows. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1115968&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-03-08 01:36:54
|
Patches item #1121104, was opened at 2005-02-12 09:41 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bleeter Yaluser (bleeter) Assigned to: Tim Ringenbach (marv_sf) Summary: Yahoo privacy fixes Initial Comment: The yahoo prpl has no real concept of privacy, beyond what Yahoo servers offer. Here's a patch that addresses most of these issues. 1) Introduce a privacy check routine. Ideally, this should be in privacy.c, but it's esier to submit in here for the moment, for simple testing. If people think it's worthy to be added before complete privacy rewrite, it can be moved. 2) Each incoming message can be checked against this function. Thus, all typing, IMs and chat invites can be blocked. 3) The permit/deny list is now active. As yahoo protocol has no concept beyond blocking, this acts locally only. I've submitted to head, as although I believe this is actually a bugfix, it's best to submit here and backport (although it was written against oldstatus and forward poted originally) ---------------------------------------------------------------------- >Comment By: Bleeter Yaluser (bleeter) Date: 2005-03-08 12:36 Message: Logged In: YES user_id=407708 Yes, I realised I'd not blocked chat invites after I posted this. I've added it to my later versions ;-) I did originally have buckets of debug in the code, but ripped most of it out for publishing. I'll put what you sugegst back in. Whitespace fix won't be a problem :-) I'd tried keeping formatting consistency with other gaim code, but as ou know, that's not always a useful guide ;-) Should have an update for you in 24 hours or so. Do you want a 1.x backport as well? Actually, it originates as a 1.x patch, and I forwardport. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2005-03-08 11:50 Message: Logged In: YES user_id=790708 Actually, you just block conference invites, not chat invites. You might want to block both. I don't suppose you could work in some kind of gaim_debug warning if we receive an IM from someone on the block list when we're in "block the users below"? Because we shouldn't be getting IM's from users like that, and covering up the bug will just make it harder to fix. (the bug being the people aren't ending up on the server side block list) Also, could you fix the whitespace? Like, the switch statement isn't indented at all. Nothing should be not indented at all except function names and the opening { for the function.. I do usually have the switch and the cases below it at the same indentation level, e.g.: switch () { case: default: } I don't know how right that is, or if gaim has a genereal rule for it though. Also, I usually put no space between a function and the (), like "printf("hello!");", but I always put a space if it's a flow control thingy, like "if (foo != bar) {" For multiline functions, something like <tab>printf("%s%s%s", <tab><space><space><space><space>blah, blah, blah); Is probably better, than multiple tabs. The important thing is the same number of tabs is used on both lines, so the line looks right whether the tab is 4 or 8 spaces. Also, you should probably use gaim_debug_info() instead of gaim_debug(GAIM_DEBUG_INFO) I think that's all the nit picking for now. If you fix at least some of what i complained about i'll apply it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1121104&group_id=235 |
3 messages has been excluded from this view by a project administrator.
