Menu
▾
▴
pidgin-patches — Updates to the Gaim patches tracker
You can subscribe to this list here.
| 2004 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(435) |
Dec
(252) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2005 |
Jan
(177) |
Feb
(157) |
Mar
(187) |
Apr
(168) |
May
(127) |
Jun
(291) |
Jul
(38) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: SourceForge.net <no...@so...> - 2005-04-11 02:40:19
|
Patches item #1180447, was opened at 2005-04-10 21:40 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180447&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: gaim_buddy_icons_set_cache_dir Initial Comment: The g_return_if_fail precondition doesn't make sense with the rest of the logic. It looks like a typo. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180447&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-11 02:31:15
|
Patches item #1180439, was opened at 2005-04-10 21:14 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180439&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) >Summary: GTK+ Naming Initial Comment: Sometimes I'm too crazy for my own good. Inconsistency bothers me, so here's a patch that normalizes many, and hopefully all, occurrences of GTK+. ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-04-10 21:31 Message: Logged In: YES user_id=156487 Adding a patch of similar changes for the FAQ on the website. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180439&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-11 02:22:17
|
Patches item #1180444, was opened at 2005-04-10 21:22 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180444&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Spacing Normalization Initial Comment: A variety of spacing normalization I've done as I've navigated the source making other changes. The specific changes should be uncontroversial. I'm submitting these to shrink the deltas between my local tree and the CVS source. If spacing changes are unwelcome as a general rule, let me know. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180444&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-11 02:15:09
|
Patches item #1180440, was opened at 2005-04-10 21:15 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180440&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Two Minor Spelling Fixes in Comments Initial Comment: The summary says it all. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180440&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-11 02:14:12
|
Patches item #1180439, was opened at 2005-04-10 21:14 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180439&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: GTK Naming Initial Comment: Sometimes I'm too crazy for my own good. Inconsistency bothers me, so here's a patch that normalizes many, and hopefully all, occurrences of GTK+. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180439&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-11 02:01:25
|
Patches item #1180436, was opened at 2005-04-10 21:01 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180436&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: About Box Cleanup Initial Comment: This patch started as an effort to either fix the bug that occurs when two translator's e-mail addresses are listed or to fill out the Debugging Information section with lines for all the #defines configure can set. Anyway, it fixes both of those issues and makes things in the about box a lot more consistent. If the change from tabs to spaces to line things up is a deal-breaker for accepting this patch, I can redo it. Spaces are better, in my opinion, for lining things up (vs. identing where tabs are superior) because they're unaffected by varying tab settings. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180436&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-11 00:47:19
|
Patches item #1180089, was opened at 2005-04-10 03:55 Message generated for change (Settings changed) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180089&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) >Assigned to: Mark Doliner (thekingant) Summary: oscar.c Authorization Dialog Escaping Initial Comment: I woke up this morning and found another blank dialog box. Some random guy had added me on ICQ it seemed. Anyway, I tracked the bug down to oscar.c. This patch should fix it. Testing shows that I can properly receive authorization messages with HTML special characters (<, >, and &). ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-10 14:55 Message: Logged In: YES user_id=156487 This was for HEAD. I didn't notice the escaping in gtkrequest.c before. I don't know what's happening. If it's being escaped twice like this suggests, I should've seen < > and & in the dialog box, which I didn't. Something weird is going on. I'll look into it some more. ---------------------------------------------------------------------- Comment By: Stu Tomlinson (nosnilmot) Date: 2005-04-10 09:13 Message: Logged In: YES user_id=309779 is this for HEAD or oldstatus? (HEAD is doing escaping in gtkrequest.c, so this shouldn't be necessary for HEAD, but if it is, something's wrong elsewhere) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180089&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-11 00:22:52
|
Patches item #1179438, was opened at 2005-04-08 16:17 Message generated for change (Comment added) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179438&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Conversation Window "View Log" Initial Comment: (00:10:41) Sean Egan (seanegan): also, contact-log-viewerize the conversation windows. ---------------------------------------------------------------------- >Comment By: Luke Schierer (lschiere) Date: 2005-04-10 20:22 Message: Logged In: YES user_id=28833 thanks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179438&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-11 00:19:48
|
Patches item #1179674, was opened at 2005-04-09 04:57 Message generated for change (Comment added) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179674&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: ChangeLog.API Entry for Signal Changes Initial Comment: I should've included this in my signal patch that was recently accepted for HEAD. ---------------------------------------------------------------------- >Comment By: Luke Schierer (lschiere) Date: 2005-04-10 20:19 Message: Logged In: YES user_id=28833 thanks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179674&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-11 00:18:40
|
Patches item #1179652, was opened at 2005-04-09 02:41 Message generated for change (Settings changed) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179652&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) >Assigned to: Ethan Blanton (eblanton) Summary: IRC Quit Messages Initial Comment: If no IRC quit message is provided, don't show "quit: ". ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179652&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-10 22:05:09
|
Patches item #1180355, was opened at 2005-04-10 17:48 Message generated for change (Comment added) made by faceprint You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180355&group_id=235 Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Fix HEAD So It Compiles Initial Comment: faceprint removed gaim_find_conversation. It was used in one place in Gaim. This patch changes that to use gaim_find_conversation_with_account. It also adds the ChangeLog.API entry for the removal of that public function. ---------------------------------------------------------------------- >Comment By: Nathan Walp (faceprint) Date: 2005-04-10 18:05 Message: Logged In: YES user_id=17471 i forgot to commit this file initially, sorry ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180355&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-10 21:48:10
|
Patches item #1180355, was opened at 2005-04-10 16:48 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180355&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Fix HEAD So It Compiles Initial Comment: faceprint removed gaim_find_conversation. It was used in one place in Gaim. This patch changes that to use gaim_find_conversation_with_account. It also adds the ChangeLog.API entry for the removal of that public function. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180355&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-10 18:55:02
|
Patches item #1180089, was opened at 2005-04-10 02:55 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180089&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: oscar.c Authorization Dialog Escaping Initial Comment: I woke up this morning and found another blank dialog box. Some random guy had added me on ICQ it seemed. Anyway, I tracked the bug down to oscar.c. This patch should fix it. Testing shows that I can properly receive authorization messages with HTML special characters (<, >, and &). ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-04-10 13:55 Message: Logged In: YES user_id=156487 This was for HEAD. I didn't notice the escaping in gtkrequest.c before. I don't know what's happening. If it's being escaped twice like this suggests, I should've seen < > and & in the dialog box, which I didn't. Something weird is going on. I'll look into it some more. ---------------------------------------------------------------------- Comment By: Stu Tomlinson (nosnilmot) Date: 2005-04-10 08:13 Message: Logged In: YES user_id=309779 is this for HEAD or oldstatus? (HEAD is doing escaping in gtkrequest.c, so this shouldn't be necessary for HEAD, but if it is, something's wrong elsewhere) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180089&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-10 13:13:06
|
Patches item #1180089, was opened at 2005-04-10 02:55 Message generated for change (Comment added) made by nosnilmot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180089&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: oscar.c Authorization Dialog Escaping Initial Comment: I woke up this morning and found another blank dialog box. Some random guy had added me on ICQ it seemed. Anyway, I tracked the bug down to oscar.c. This patch should fix it. Testing shows that I can properly receive authorization messages with HTML special characters (<, >, and &). ---------------------------------------------------------------------- >Comment By: Stu Tomlinson (nosnilmot) Date: 2005-04-10 08:13 Message: Logged In: YES user_id=309779 is this for HEAD or oldstatus? (HEAD is doing escaping in gtkrequest.c, so this shouldn't be necessary for HEAD, but if it is, something's wrong elsewhere) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180089&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-10 10:43:31
|
Patches item #1180138, was opened at 2005-04-10 12:43 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180138&group_id=235 Category: i18n Group: None Status: Open Resolution: None Priority: 5 Submitted By: Vajna Miklós (vmiklos) Assigned to: Nobody/Anonymous (nobody) Summary: hungarian descs in gaim.desktop Initial Comment: Name[hu], GenericName[hu], Comment[hu] fields in gaim.desktop here is the url of the patch: http://ftp.frugalware.org/pub/frugalware/frugalware-current/source/xapps/gaim/00-gaim-1.1.3-hu.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180138&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-10 07:55:47
|
Patches item #1180089, was opened at 2005-04-10 02:55 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180089&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: oscar.c Authorization Dialog Escaping Initial Comment: I woke up this morning and found another blank dialog box. Some random guy had added me on ICQ it seemed. Anyway, I tracked the bug down to oscar.c. This patch should fix it. Testing shows that I can properly receive authorization messages with HTML special characters (<, >, and &). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180089&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-09 08:57:16
|
Patches item #1179674, was opened at 2005-04-09 03:57 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179674&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: ChangeLog.API Entry for Signal Changes Initial Comment: I should've included this in my signal patch that was recently accepted for HEAD. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179674&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-09 06:41:19
|
Patches item #1179652, was opened at 2005-04-09 01:41 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179652&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: IRC Quit Messages Initial Comment: If no IRC quit message is provided, don't show "quit: ". ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179652&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-08 20:17:11
|
Patches item #1179438, was opened at 2005-04-08 15:17 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179438&group_id=235 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Conversation Window "View Log" Initial Comment: (00:10:41) Sean Egan (seanegan): also, contact-log-viewerize the conversation windows. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1179438&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-07 15:23:10
|
Patches item #1178248, was opened at 2005-04-06 23:41 Message generated for change (Settings changed) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1178248&group_id=235 Category: newfeature Group: None Status: Open Resolution: None Priority: 5 Submitted By: Matt Amato (matt_amato) >Assigned to: Etan Reisner (deryni9) Summary: [oldstatus] Signals for Add/Remove Buddy Initial Comment: This is a simple patch that registers two new signals. One for when a buddy is added to the buddy list and another for when he/she is removed. The added signal is emitted after the buddy is fully added and the remove signal is emitted after the buddy is removed but just before the memory associated with the buddy is freed. I also updated signals-test.c to register and test these signals. This is also my first patch for any OSS project, so go easy on me. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1178248&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-07 15:22:28
|
Patches item #1178273, was opened at 2005-04-07 01:18 Message generated for change (Comment added) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1178273&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Autocomplete Accounts Initial Comment: When you autocomplete a screenname in a dialog box that also includes an account selector, it should also autocomplete the account. This patch implements that. ---------------------------------------------------------------------- >Comment By: Luke Schierer (lschiere) Date: 2005-04-07 11:22 Message: Logged In: YES user_id=28833 thanks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1178273&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-07 14:55:16
|
Patches item #1178217, was opened at 2005-04-06 21:40 Message generated for change (Comment added) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1178217&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: [HEAD] Signal Short Circuiting Initial Comment: The following log snippets should explain it: (20:24:00) rlaager: Regarding the signal handling conversation the other day... I've written a patch to stop calling signal handlers and return as soon as we find one signal handler that returns TRUE to indicate that it's handled the signal. Is this the right approach? (20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's documented to behave exactly the way it does (20:24:31) Ethan Blanton (Paco-Paco): so changing it is notbackwards compatible (20:24:31) rlaager: I'm talking for HEAD. (20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a good approach, yes (20:24:53) rlaager: The way I've described is how I *expected* it to work, having not read the documentation. (20:25:09) Ethan Blanton (Paco-Paco): I'm convinced (20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I assume, breaks the generic-ness of signals, by assuming that any that return values return booleans? (20:27:26) Ethan Blanton (Paco-Paco): please break it (20:27:33) Ethan Blanton (Paco-Paco): we already have out-parameters (20:27:42) rlaager: nosnilmot: from what I can see, the return type is handled as a (void *)... so I'm checking that ret_value != NULL (20:27:57) rlaager: nosnilmot: that's the correct way to do it, right? ... (20:29:01) Ethan Blanton (Paco-Paco): allowing a meaningful return value is an over-engineering (20:30:07) rlaager: even after this patch, you should be able to return meaningful return values (20:30:15) rlaager: it'll just short-circuit on the first handler that does ---------------------------------------------------------------------- >Comment By: Luke Schierer (lschiere) Date: 2005-04-07 10:55 Message: Logged In: YES user_id=28833 thanks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1178217&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-07 14:42:03
|
Patches item #1178208, was opened at 2005-04-06 21:10 Message generated for change (Comment added) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1178208&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: gaim_cmd_do_command Documentation Fix Initial Comment: You can't pass NULL as errormsg as the documentation implies. If you do, it segfaults. Perhaps that should be allowable, but as the code stands, it's not. The documentation should be updated in HEAD and oldstatus to reflect this. Attached is a patch to that effect. ---------------------------------------------------------------------- >Comment By: Luke Schierer (lschiere) Date: 2005-04-07 10:42 Message: Logged In: YES user_id=28833 thanks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1178208&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-07 14:36:04
|
Patches item #1166073, was opened at 2005-03-18 11:38 Message generated for change (Comment added) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1166073&group_id=235 Category: Plugins Group: None >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Benjamin Kahn (xkahn) Assigned to: Sean Egan (seanegan) Summary: Make the autocorrect plugin work Initial Comment: Autocorrect in gaim... um... sucks. The problem is that the correction only happens AFTER you send a message. This means that you don't actually know what message you are sending until it is sent. Horrible. My new patch works AS YOU TYPE with the following rules: * You must be typing, not pasting in text. If you paste in teh and there is a rule to correct teh to the, it won't be corrected. This is because it would be impossible to go back and check all the text. * Check whole words ONLY. Partial words don't count. * If the dictionary word has capital letters in it, match only words with that capitalization. (FPT -> FTP doesn't match ftp.) * If the dictionary word doesn't have capital letters, preserve the capitalization the user used. (The code assumes three possible capitalization schemes: ALLCAPS, lowercase, and Proper.) Unless the solution has capital letters. In that case, force the capitalization used in the solution. * A word may have quote characters in it and still be a word. * If the user immediately hits the backspace key after a correction, undo the correction. ---------------------------------------------------------------------- >Comment By: Luke Schierer (lschiere) Date: 2005-04-07 10:36 Message: Logged In: YES user_id=28833 thanks, I accepted the version rlaager posted, crediting both of you. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-03 22:37 Message: Logged In: YES user_id=156487 xkahn, this is beautiful work. It's exactly what I was looking to do myself. I'm glad you wrote it and saved me the work! I've cleaned up this patch a bit to make it conform to the coding style in use in Gaim. I made a couple other little fixes and added a couple items off my TODO list. This patch (a strict* superset of the changes applied by these two patches) is available at: http://sf.net/support/tracker.php?aid=1176125 * Except for the fact that there were a couple typos in the correction list in gaim-0.81-defaults.patch. Yes, I mean typos in the replacement string, not the string to be replaced. I found it slightly ironic. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-03 15:58 Message: Logged In: YES user_id=156487 Hmm, it seems you beat me to all the things I was going to do with the text replacement plugin. I haven't yet looked at this patch, but from the description it sounds nice. I have a large list of autocorrections I've been testing. Feel free to e-mail me and I'll send it your way. Otherwise, I'll submit a patch with them if/when this is accepted. ---------------------------------------------------------------------- Comment By: Benjamin Kahn (xkahn) Date: 2005-03-18 11:49 Message: Logged In: YES user_id=7632 Umm... Regarding the first point: * You must be typing, not pasting in text. If you paste in teh and there is a rule to correct teh to the, it won't be corrected. This is because it would be impossible to go back and check all the text. It is possible for the code to do this, however it purposely does NOT. This is because because pasted text is normally fairly long and may have multiple subtle corrections. This makes it difficult for users to understand what is happening and spot errors. Also, pasted text is often either wrong on purpose (and then he said: "hey d00d!"), or correct already. ---------------------------------------------------------------------- Comment By: Benjamin Kahn (xkahn) Date: 2005-03-18 11:41 Message: Logged In: YES user_id=7632 Oh! And we'll need some good text replacements. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1166073&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-04-07 14:35:44
|
Patches item #1176125, was opened at 2005-04-03 22:33 Message generated for change (Comment added) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1176125&group_id=235 Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Sean Egan (seanegan) Summary: Text Replacement Plugin Fixes Initial Comment: This patch is based off xkahn's work available at: http://sf.net/support/tracker.php?aid=300235 Most of the changes are his. I just changed his formatting to match the rest of Gaim more closely. Also, I made a couple coding style changes. The two biggest changes I made were: 1) I added some hash stuff to load_config. This removes duplicates. 2) I imported my list of text replacement strings as the default list in addition to xkahn's list. My list consisted primarily of the autocorrect entries from my copy of OpenOffice.org Writer. There were a few things I've added by hand. (For those familiar with my comments in #gaim, this list does NOT include anything like a pwn -> own replacement. If people want to talk like that, I'm not going to stop them. This list should be useful to anyone.) I also fixed a memory leak in load_config. A GtkListStore stores its own copy of strings, so there is no need to g_strdup them when appending to the GtkListStore. When I get a chance, I need to make it give an error if you try to set a duplicate "You type" word in the preferences. Otherwise, this patch should take care of everything. I would recommend considering this patch over xkahn's because it's a direct superset of his patches. However, I want to be very clear that most of the changes in this patch are his and he deserves the credit for them. ---------------------------------------------------------------------- >Comment By: Luke Schierer (lschiere) Date: 2005-04-07 10:35 Message: Logged In: YES user_id=28833 thanks to both of you. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-06 23:20 Message: Logged In: YES user_id=156487 I fixed the problem that xkahn pointed out here. I had discovered that independently; I only saw his posting now. Yes, xkahn, it was fairly simple to fix. I also fixed the last item from my TODO list. It now presents an error if you try to add a duplicate "BAD" word. Finally, I've merged in some more autocorrections from word processors. As I noted in a comment, the ones with spaces don't currently work, but I'm leaving them in case someone modifies the plugin in the future to handle that case. I think it's good enough for me, so I'm not going to put in the work to handle multi-word corrections as that opens a giant can of worms. Oh, this patch also adds Benjamin Kahn to the COPYRIGHT file. This patch should be directly committable now. ---------------------------------------------------------------------- Comment By: Benjamin Kahn (xkahn) Date: 2005-04-03 23:19 Message: Logged In: YES user_id=7632 So there is a major problem with my patch which your patch hasn't fixed yet. I included an "undo" feature which allows users to cancel changes to auto-correct if they hit backspace right after the change is made. The problem is that the undo feature is a little too enthusiastic. It will replace a word if you hit space even after you have moved the cursor. (Possibly only after moving the cursor with the pointer, although I no longer remember.) Also, if you hit backspace to get the word uncorrected, and then hit space again to advance, the word is auto-corrected once more. Not very friendly. This shouldn't be too hard to fix, but I haven't bothered since the patch shows no signs of being incorporated. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1176125&group_id=235 |
3 messages has been excluded from this view by a project administrator.
