Re: [Gaim-devel] patch for crash when log signons is on and connect is cancelled

[Ka-Hing C. <ja...@ja...>]

On Tue, Apr 13, 2004 at 10:24:05AM +0200, mdavis_mailbox wrote:
> Hi,
> 
> This is a patch to fix the case when 'Log your own
> signons/idleness/awayness' is on and a connection is cancelled while
> connecting. My first patch, so be gentle if I got it wrong :-)
> 
> The problem is that account->gc is NULL under these circumstances and yet it
> gets used for account->gc->login_time in 'gaim_account_get_log'.

Are you sure this will fix the problem? IIRC nothing ever checks the return
value of gaim_account_get_log before using it. Also, even w/o this patch,
cancelling the connection does not always result in a segfault.

Well, if this fixes it, Luke will be happy.

-khc