Menu
▾
▴
[Gaim-patches] [ gaim-Patches-908560 ] Yahoo: Don't add invalid screen names to buddy list
|
From: SourceForge.net <no...@so...> - 2005-04-28 23:17:54
|
Patches item #908560, was opened at 2004-03-02 15:14 Message generated for change (Comment added) made by marv_sf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=908560&group_id=235 Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Stu Tomlinson (nosnilmot) Assigned to: Stu Tomlinson (nosnilmot) Summary: Yahoo: Don't add invalid screen names to buddy list Initial Comment: This patch adds a yahoo_snvalid function to validate a yahoo screen name (it must contain only letters, numbers and underscores). If an invalid screen name is added to the buddy list, there will be no attempt to add it to the server list, and it will be removed from the local list. Additionally, if the server reports that an added screen name is invalid, it will be removed from the local list. ---------------------------------------------------------------------- >Comment By: Tim Ringenbach (marv_sf) Date: 2005-04-28 18:17 Message: Logged In: YES user_id=790708 just for the record, my problem with this patch was reports that illegal yahoo ids were in fact legal in some circumstances, or at least that people were using them illegally. ---------------------------------------------------------------------- Comment By: Stu Tomlinson (nosnilmot) Date: 2005-04-28 13:31 Message: Logged In: YES user_id=309779 I committed the interesting part of this (the util function for validating email addresses) a while ago in some unrelated thingy. As I've never seen any reports of adding invalid Yahoo! IDs actually causing any problems, I'm rejecting this patch. I'm sure the submitter will be really disappointed. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2004-11-23 22:52 Message: Logged In: YES user_id=790708 I'll reassign this one to its author. I'd be careful here, it's hard to tell which characters are legal, even if you can't make a yahoo id with them from yahoo's site, someone might get a sn with them somehow anyway. On the other hand, if we do block a valid username, someone will report a bug, and then we can update the list. ---------------------------------------------------------------------- Comment By: Stu Tomlinson (nosnilmot) Date: 2004-03-02 19:24 Message: Logged In: YES user_id=309779 This updated patch adds a function to gaim's util.c to validate email addresses, to allow for the "Yahoo partner" scenario referenced by my earlier comment. Also based on observations (thanks marv!) in yahoo chat rooms, a few additional characters are allowed even if they do not strictly seem to be legitimate screen names (!, -, ., #) Another minor tweak is that an attempt to send an IM to an invalid screen name will result in an "Unable to send" error reported to the user. ---------------------------------------------------------------------- Comment By: Stu Tomlinson (nosnilmot) Date: 2004-03-02 15:58 Message: Logged In: YES user_id=309779 Maybe I should have done a bit more research: http://help.yahoo.com/help/us/edit/edit-24.html ---------------------------------------------------------------------- Comment By: Stu Tomlinson (nosnilmot) Date: 2004-03-02 15:55 Message: Logged In: YES user_id=309779 Try to register a screen name with spaces in it here: http://edit.yahoo.com/config/eval_register and it will then (and only then, which is not very helpful) tell you that the screen name must contain only letters, numbers and underscores. It could of course be wrong, and adding '@' to the accepted list wouldn't be hard. ---------------------------------------------------------------------- Comment By: Tim Ringenbach (marv_sf) Date: 2004-03-02 15:47 Message: Logged In: YES user_id=790708 Where did you get the "letters, numbers and underscores" from? (Just curious, and/or wanting to read the source for myself in case it has other useful info.) I've seen Yahoo! screen names with @'s in them before too. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=908560&group_id=235 |