[Gaim-patches] [ gaim-Patches-982227 ] docklet: play message received sound when message is waiting

[SourceForge.net <no...@so...>]

Patches item #982227, was opened at 2004-06-29 16:13
Message generated for change (Comment added) made by seanegan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=982227&group_id=235

Category: None
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: Casey Harkins (charkins)
Assigned to: Sean Egan (seanegan)
Summary: docklet: play message received sound when message is waiting

Initial Comment:
This patch to the system tray plugin adds a preference
option to play the message received sound when a
message is waiting. The sound is played when the status
changes to online_pending.

----------------------------------------------------------------------

>Comment By: Sean Egan (seanegan)
Date: 2005-03-13 18:13

Message:
Logged In: YES 
user_id=199625

Unless I'm mistaken, this patch will only play a sound the
first time a message is received while messages are queued.
That's no good.

I agree that using the signals mechanism is a good solution.
Look at how pounces work for pointers.

-s.

----------------------------------------------------------------------

Comment By: Casey Harkins (charkins)
Date: 2005-03-08 11:40

Message:
Logged In: YES 
user_id=254876

For the record, I think the correct approach to fixing this
and potentially other sound issues is to move all existing
gaim sound code into a plugin. Sound events already occur is
situations where a signal is being emitted. Using a plugin
would allow the sounds to be de-coupled from the interface
(the problem in this particular case). It should also
simplify the codebase as sound support would be entirely
self contained within a plugin instead of littered
throughout the core components. I had started work on this a
few months ago, but haven't found time to finish it up. I
was planning on working on this again soon, unless someone
beats me to it.

Anyone agree or disagree with moving all sound support into
a plugin? 

----------------------------------------------------------------------

Comment By: Casey Harkins (charkins)
Date: 2004-08-20 16:48

Message:
Logged In: YES 
user_id=254876

I'm not sure that this patch uses the right approach. The
correct way to handle this would be for gaim to play sounds
for received messages as they are received, rather than when
the window is open. This patch just adds an extra sound that
plays when the docklet icon changes status (to
online_pending). If I get a chance, I'll take a look at
implementing this correctly.


----------------------------------------------------------------------

Comment By: Casey Harkins (charkins)
Date: 2004-06-29 16:25

Message:
Logged In: YES 
user_id=254876

This cooresponds to RFE #966977

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=982227&group_id=235