From: Nathan W. <fac...@fa...> - 2002-10-19 15:42:18
|
On Sat, Oct 19, 2002 at 01:30:38PM +0200, David Odin wrote: > - You've replace the 'entry_view' field by 'entry'. I guess it was to > reduce the patch size. I'm afraid this could cause some hard-to-find > bugs because the 'entry' field can be used with its former meaning > (i.e a pointer to a GtkText, not a GtkTextView) by other part of > gaim's code. Well, once you changed it to entry_view, we were 100% certain that we had gotten all instances of it, so it was changed back. New uses of the field in the old manner won't magically appear, and this makes the diff much easier to parse, and see the true functionality changes. Nathan --=20 Nathan Walp || fac...@fa... GPG Fingerprint: || http://faceprint.com/ 5509 6EF3 928B 2363 9B2B DA17 3E46 2CDC 492D DB7E |