[Gaim-patches] [ gaim-Patches-1093125 ] Maintain formatting between messages within a conversation

[SourceForge.net <no...@so...>]

Patches item #1093125, was opened at 2004-12-30 00:55
Message generated for change (Comment added) made by lschiere
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1093125&group_id=235

Category: newfeature
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Bron Gondwana (brong)
Assigned to: Sean Egan (seanegan)
Summary: Maintain formatting between messages within a conversation

Initial Comment:
This patch (cvs diff -u) against anonCVS at: Thu Dec 30
05:49:57 UTC 2004 copies the formatting from the
previous message into the next message with a
conversation, allowing you to maintain the same font
and colo(u)r settings between messages.

This adds one extra configuration variable, a boolean
named: /gaim/gtk/conversations/maintain_format and also
a checkbox on the "Message Text" preferences pane to
control the setting.

This is my first patch, so please let me know if I'm
doing anything wrong and I'll try to fix it.

Regards,

Bron.

----------------------------------------------------------------------

>Comment By: Luke Schierer (lschiere)
Date: 2004-12-30 08:27

Message:
Logged In: YES 
user_id=28833

myself, more than wanting some formatting change to stick
around, i've consistently wanted an easy way to get back to
default formatting after changing some string or pasting in
some formatted text. 

----------------------------------------------------------------------

Comment By: Bron Gondwana (brong)
Date: 2004-12-30 03:21

Message:
Logged In: YES 
user_id=9941

I wrote it because one of the people I chat to regularly
uses the MSN client, and has difficulty in a multi person
chat distinguishing the black text of my messages from the
black text of all the junk MSN throws on the screen.

On the other hand, I also use Gaim for business
communication where funky colours aren't appropriate.

An alternative would be defaults per person, but that
appeared more complicated to implement.

re: does too much.  I did try removing the call to reset
formatting, and it messed up in various circumstances - I
wish I'd kept notes on it, but this seemed the least
invasive approach.  I will try again and see if I can work
out why I chose this approach.  I've been running this patch
on 1.1.0 and 1.1.1 for the past few weeks, and decided to
apply it to CVS so I could feed it back.

In summary: I'd be happy with formatting per contact or per
conversation, but only one default formatting for every
conversation across multiple protocols doesn't work for me
because I use the same chat program for multiple different
'roles'.

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2004-12-30 03:03

Message:
Logged In: YES 
user_id=199625

Mark is right that this would make a crappy preference. 
This is either a feature we want on or off.

My next thought is that it seems the patch does too much.  I
think just removing the call to reset formatting would do
the trick.

As to whether we actually want this... I don't know.  I can
think of times I wished the formatting did hold over, but I
think it's probably occured more that I'm glad it didn't.

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2004-12-30 01:11

Message:
Logged In: YES 
user_id=20979

I think we're probably not willing to accept a patch that
adds this preference.  We've been trying zealously to remove
as many preferences as possible, to keep the application
simple and clean.

This patch isn't vital because there already exists the
preferences for default message text formatting.  But it
WOULD be a nice thing to have.  Hopefully some other people
will comment on it, but I think I would want this feature
only if there is a "reset to default formatting" button on
the gkimhtmltoolbar.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1093125&group_id=235