[Gaim-patches] [ gaim-Patches-1074853 ] HEAD jabber signoff crash fix / status send fix

[SourceForge.net <no...@so...>]

Patches item #1074853, was opened at 2004-11-28 16:40
Message generated for change (Comment added) made by datallah
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1074853&group_id=235

Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Submitted By: Daniel Atallah (datallah)
Assigned to: Nathan Walp (faceprint)
Summary: HEAD jabber signoff crash fix / status send fix

Initial Comment:
In the HEAD, jabber crashes when signing off.

This is because when signing off, jabber tries to reset
the status on the server using a reference to the
GaimConnection that is not valid.

There was a recent change that caused all jabber status
updates to use GaimAccount->gc instead of passing in a
connection directly.  This is fine in all cases, except
when disconnecting because account->gc is set to NULL
during the disconnection process, but before the
GaimConnection itself is actually terminated.

Basically, the fix is that when jabber_presence_send(),
is called from jabber_close(), it needs to use the
GaimConnection* that was passed to jabber_close()
instead of the pointer to the connection that is in the
account.

This patch doesn't change how anything is intended to
work, it just makes things work in the way they were
intended to. :)

----------------------------------------------------------------------

>Comment By: Daniel Atallah (datallah)
Date: 2004-12-16 21:54

Message:
Logged In: YES 
user_id=325843

marv did what he was thinking about, so this isn't necessary
any more.

----------------------------------------------------------------------

Comment By: Daniel Atallah (datallah)
Date: 2004-12-15 16:07

Message:
Logged In: YES 
user_id=325843

That would also accomplish the task, but i'm not sure what
else that would affect.

----------------------------------------------------------------------

Comment By: Tim Ringenbach (marv_sf)
Date: 2004-12-15 15:48

Message:
Logged In: YES 
user_id=790708

Why don't we just wait until after the protocol callback to
set account->gc to NULL?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1074853&group_id=235