Menu
▾
▴
[Gaim-patches] [ gaim-Patches-1078151 ] [MSN] Real bugfix
|
From: SourceForge.net <no...@so...> - 2004-12-03 15:14:45
|
Patches item #1078151, was opened at 2004-12-03 02:40 Message generated for change (Comment added) made by nosnilmot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1078151&group_id=235 Category: segfault Group: None Status: Open Resolution: None Priority: 7 Submitted By: Felipe Contreras (revo) Assigned to: Stu Tomlinson (nosnilmot) Summary: [MSN] Real bugfix Initial Comment: Well, I found it out. User Dislpay messages, and other less used, did not set an slpcall, so the callback that should not be called, was called (in some very special cases). So it's a real bug fix, and an even more efficient implementation ;). BTW. Someone should grammatically check this: "The slpcall in which this slp message was sent" ---------------------------------------------------------------------- >Comment By: Stu Tomlinson (nosnilmot) Date: 2004-12-03 10:14 Message: Logged In: YES user_id=309779 Was this supposed to fix the 'User signs off while we're receiving their buddy icon' bug? I just managed to reproduce that *with* this patch applied. <...> (10:08:00) msn: S: SB 002: MSG us...@do...o Stu 1344 (10:08:01) msn: S: SB 001: MSG us...@do...o Stu 1350 (10:08:01) msn: S: SB 001: ACK 6 (10:08:01) msn: S: SB 002: MSG us...@do...o Stu 1344 (10:08:01) msn: S: NS 000: FLN us...@do...o (10:08:01) msn: End User Display (10:08:01) msn: buddy_icon_window=5 (10:08:01) msn: Releasing buddy icon request (10:08:01) msn: Couldn't find slpmsg (10:08:01) g_log: file slplink.c: line 527 (msn_slplink_process_msg): should not be reached (10:08:01) msn: S: SB 002: ACK 6 Program received signal SIGSEGV, Segmentation fault. 0x4061ef3c in g_list_remove () from /usr/lib/libglib-2.0.so.0 (gdb) bt #0 0x4061ef3c in g_list_remove () from /usr/lib/libglib-2.0.so.0 #1 0x40d38ff1 in msn_slpmsg_destroy (slpmsg=0x8852198) at slpmsg.c:66 #2 0x40d38415 in msg_ack (data=0x8852198) at slplink.c:249 #3 0x40d39ef8 in msg_ack (cmdproc=0x84da470, cmd=0x8852198) at switchboard.c:529 #4 0x40d2b1e6 in msn_cmdproc_process_cmd (cmdproc=0x84da470, cmd=0x8272350) at cmdproc.c:309 #5 0x40d2b30f in msn_cmdproc_process_cmd_text (cmdproc=0x84da470, command=0x1 <Address 0x1 out of bounds>) at cmdproc.c:342 #6 0x40d36028 in read_cb (data=0x8847d38, source=8, cond=GAIM_INPUT_READ) at servconn.c:414 #7 0x080bb13d in gaim_gtk_io_invoke (source=0x8650bb8, condition=142942616, data=0x885cd80) at gtkeventloop.c:61 #8 0x4063e18f in g_vsnprintf () from /usr/lib/libglib-2.0.so.0 #9 0x406214b6 in unblock_source () from /usr/lib/libglib-2.0.so.0 #10 0x406223e9 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #11 0x406226ef in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0 #12 0x40622d4e in g_main_loop_run () from /usr/lib/libglib-2.0.so.0 #13 0x401ce95b in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #14 0x080df390 in main (argc=3, argv=0xbffff144) at main.c:965 #15 0x42015967 in __libc_start_main () from /lib/i686/libc.so.6 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1078151&group_id=235 |