[Gaim-patches] [ gaim-Patches-704403 ] OPT_IM_ONE_WINDOW implementation

[SourceForge.net <no...@so...>]

Patches item #704403, was opened at 2003-03-16 02:24
Message generated for change (Comment added) made by lschiere
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=704403&group_id=235

Category: newfeature
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Ben Wolfson (rumjuggler)
>Assigned to: Sean Egan (seanegan)
Summary: OPT_IM_ONE_WINDOW implementation

Initial Comment:
with the gaim CVS as of last night (20030313) the
option OPT_IM_ONE_WINDOW doesn't do anything, because
the function im_tabize() (which is in an #if 0 block in
prefs.c) is unwritten.  This patch provides an
implementation of that function (placed in gtkconv.c,
because that seemed like an ok place for it--maybe
conversations.c is better?) and causes new
conversations to be created in their own windows when
this option is not set.

NB the patch as it stands does not pay attention to the
option governing whether or not to put chats and ims in
the same window; this is pretty trivial and I'm just
submitting the patch as-is to see what the response is.
 I can add it in pretty easily.

----------------------------------------------------------------------

>Comment By: Luke Schierer (lschiere)
Date: 2004-11-19 15:41

Message:
Logged In: YES 
user_id=28833

eperez, if you'd read his comments scattered all over the
bugs, plugins, rfe, and patch tracker, all of them 2 or 3
words at most, you would consider it "spam" and not "a
review" as well. 

----------------------------------------------------------------------

Comment By: Ben Wolfson (rumjuggler)
Date: 2004-11-19 14:10

Message:
Logged In: YES 
user_id=121541

I've been using versions of gaim that don't require it, but
I think gentoo applies some patches that might address it. 
The patch is nearly two years old now anyway so if it is
still necessary I'm sure it's way out of date.  I'll grab
source from CVS this weekend and see if it is, and update it
if so (or do what lschiere said if I can--I haven't looked
at C basically since submitting this patch and never knew
any real GUI stuff.)

----------------------------------------------------------------------

Comment By: Eduardo Pérez (eperez)
Date: 2004-11-19 13:32

Message:
Logged In: YES 
user_id=60347

rumjuggler: What's the status of this patch? Is still
needed? Will you update it?
lschiere: Why the chomo review is spam?

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2004-01-27 12:36

Message:
Logged In: YES 
user_id=28833

chomo: please stop spamming the trackers. 

rumjuggler: i have not looked at this patch yet, but what i
am looking for is code to gray out the conversation
placement option when that is selected and to force its
value to "last window" (or some new value, but last window
should work equivalently) when that is selected. this should
have the side effect of making that function you implemented
unneeded. 

----------------------------------------------------------------------

Comment By: alan johnson (chomo)
Date: 2004-01-26 15:35

Message:
Logged In: YES 
user_id=943591

looks ok

----------------------------------------------------------------------

Comment By: Ben Wolfson (rumjuggler)
Date: 2003-03-16 03:00

Message:
Logged In: YES 
user_id=121541

The patch as submitted has a bug.  This should work better.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=704403&group_id=235