[Gaim-commits] CVS: gaim/src/protocols/msn msn.c,1.385,1.386

[Richard L. <rl...@us...>]

Update of /cvsroot/gaim/gaim/src/protocols/msn
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv32377/src/protocols/msn

Modified Files:
	msn.c 
Log Message:
Enable the extra warnings regardless of --enable-debug.

Enable FORTIFY_SOURCE regardless of --enable-debug, adding a --disable-fortify flag to configure.

Enable (well, stop disabling) the missing initializer warnings.
	This leads to warnings with: GValue v = {0,}; that must be worked around.
		Basically, instead of:
			GValue v = {0,};
			...
			g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
		We'd need to do:
			GValue v;
			...
			v.g_type = 0;
			g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */

Fix several cases of missing initializers.  I don't think any of these are bugs, but having this warning seems like a good idea. It might prevent us from making a mistake in the future.

While I was fixing missing initializers, I optimized substitute_simple_word in plugins/spellchk.c, in the same way as I did substitute_word before. Yes, I'm bad for committing these together.

Added a --enable-fatal-asserts flag to configure. As the name implies, this makes g_return_... guards fatal. This is a useful flag to run on a debug copy of Gaim. It will make it very clear if your changes have triggered one of these guards. It's also useful in detecting g_return_... abuse, which helps prevent crashes if Gaim is compiled with G_DISABLE_ASSERT defined.



Index: msn.c
===================================================================
RCS file: /cvsroot/gaim/gaim/src/protocols/msn/msn.c,v
retrieving revision 1.385
retrieving revision 1.386
diff -u -d -p -r1.385 -r1.386
--- msn.c	21 Dec 2005 08:24:16 -0000	1.385
+++ msn.c	21 Dec 2005 18:36:16 -0000	1.386
@@ -1896,7 +1896,9 @@ static GaimPluginProtocolInfo prpl_info 
 	NULL,					/* roomlist_expand_category */
 	msn_can_receive_file,	/* can_receive_file */
 	msn_send_file,			/* send_file */
-	msn_new_xfer			/* new_xfer */
+	msn_new_xfer,			/* new_xfer */
+	NULL,					/* whiteboard_prpl_ops */
+	NULL,					/* media_prpl_ops */
 };
 
 static GaimPluginInfo info =