From: John B. <rek...@re...> - 2006-09-26 15:56:01
|
> I do not know if you read the web page and the code. > But why would you call that function if you do not want to upload an icon? > > That NULL check does not seem to be needed in any code path anyway. I did read the article and the code before I replied, although this fact is unimportant to the discussion at hand. The mistake in the article is that the author is making blanket assumptions. "Bad" and "good" code are highly subjective when it comes to working code. In my experience, it is far more useful to approach the code asking yourself if it is necessary or right for the situation. Granted, this too is a subjective decision, particularly if you're not the one who wrote the code or don't have any understanding of the underlying protocol this code deals with. Knowing how to send a message, how to start Gaim and use it, or knowing what server to connect to does not count as understanding the protocol. While it currently *appears* that the NULL check may not be needed, that is no guarantee that it hasn't been needed in the past and won't be needed in the future. John |