[Gaim-devel] Re: [Gaim-commits] CVS: gaim/src gtkconv.c,1.756,1.757

[Adil <ad...@ya...>]

--- Richard Laager <rl...@us...> wrote:

> Update of /cvsroot/gaim/gaim/src
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv19029/src
> --- gtkconv.c	9 Mar 2006 04:02:09 -0000	1.756
> +++ gtkconv.c	13 Mar 2006 17:58:43 -0000	1.757
> @@ -1628,10 +1628,11 @@ gtkconv_chat_popup_menu_cb(GtkWidget
> *wi
>  	account = gaim_conversation_get_account(conv);
>  	gc      = account->gc;
>  
> +	g_return_if_fail(gc != NULL);
> +
>  	model =
> gtk_tree_view_get_model(GTK_TREE_VIEW(gtkchat->list));
>  
> -	if (gc != NULL)
> -		prpl_info = GAIM_PLUGIN_PROTOCOL_INFO(gc->prpl);
> +	prpl_info = GAIM_PLUGIN_PROTOCOL_INFO(gc->prpl);
>  
>  	sel =

Would it be `better' to not print an error message for the event
(because it is possible to have a chat-window for a disconnected
account), and popup a menu with disabled entries instead?

-- Adil

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com