[Gaim-devel] Re: [Gaim-commits] CVS: gaim/src gtkutils.c,1.137,1.138

[Tim R. <tim...@ep...>]

I'm pretty sure I remember Ethan explaining to me before how static 
buffers were usually better than using the heap. Ethan?

--Tim

Richard Laager wrote:
> Update of /cvsroot/gaim/gaim/src
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv27923/src
> 
> Modified Files:
> 	gtkutils.c 
> Log Message:
> I still hate static buffers.
> 
> Index: gtkutils.c
> ===================================================================
> RCS file: /cvsroot/gaim/gaim/src/gtkutils.c,v
> retrieving revision 1.137
> retrieving revision 1.138
> diff -u -d -p -r1.137 -r1.138
> --- gtkutils.c	2 Feb 2006 19:17:01 -0000	1.137
> +++ gtkutils.c	2 Feb 2006 19:17:49 -0000	1.138
> @@ -1590,15 +1590,16 @@ static GdkPixbuf *
>  overlay_status_onto_icon(GdkPixbuf *pixbuf, GaimStatusPrimitive primitive)
>  {
>  	const char *type_name;
> -	char basename[256];
> +	char *basename;
>  	char *filename;
>  	GdkPixbuf *emblem;
>  
>  	type_name = gaim_primitive_get_id_from_type(primitive);
>  
> -	g_snprintf(basename, sizeof(basename), "%s.png", type_name);
> +	basename = g_strdup_printf("%s.png", type_name);
>  	filename = g_build_filename(DATADIR, "pixmaps", "gaim", "status",
>  								"default", basename, NULL);
> +	g_free(basename);
>  	emblem = gdk_pixbuf_new_from_file(filename, NULL);
>  	g_free(filename);
>  
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
> _______________________________________________
> Gaim-commits mailing list
> Gai...@li...
> https://lists.sourceforge.net/lists/listinfo/gaim-commits
> 
>