Re: [Gaim-devel] [PATCH] Add per buddy language selection for GtkSpell

[Nathan W. <fac...@fa...>]

Mardy wrote:
> Hi all!
>   The attached patch adds the possibility of choosing the language for
> the spellchecker to use in outgoing messages (IM and chats).
> I tested it a bit, and it seems to work OK to me.
> 
> There are two issues on which I'd like some feedback:
> 1) The user selects the language to use by entering the ISO code in a
>    text field; this is quite ugly, but I was not sure whether it was
>    wise to embed the whole ISO 639 table (extended with countries, too)
>    in gaim...
> 2) Since the language field is useful for people using GtkSpell, most
>    of the code of this patch tests #ifdef USE_GTKSPELL.
>    While I don't like #defines, I couldn't come up with anything better.
> 
> Any comments will be greatly appreciated. :-)

xmlnode_get_data() returns allocated memory, so there's no reason to
g_strdup() it.  Also, you don't want the blist functions handling the
language code to be #ifdef'ed to GTKSPELL, because then if you run gaim
once without gtkspell, you lose all your language settings.  Also,
that's a UI thing invading the core, which is bad.  If
buddies/chats/conversations are going to have languages, let them have
languages.  Then let the UI decide what to do with that language, if
anything.

Actually, the best thing to do would be to just use a GaimBlistNode
setting of some standard name, rather than adding all that you did.  Its
much cleaner that way.

I believe that the next version of gtkspell is supposed to have some
sort of language selection support, although I'm sure it won't be able
to manage per-buddy settings.  I'll leave it to others to decide about
including this patch or not, as I barely use gtkspell in one language,
let alone many.

-Nathan