From: Mark D. <ma...@ki...> - 2005-12-01 13:42:31
|
On Thu, 01 Dec 2005 01:03:13 -0600, Kevin M Stange wrote > Mark Doliner wrote: > > On Wed, 30 Nov 2005 20:40:43 -0500 (EST), Adil wrote > >> --- Mark Doliner <the...@us...> wrote: > >> > >>> Log Message: > >>> sf patch #1370473, from Sadrul Habib Chowdhury > >>> "This patch fixes the idle time tracking for systems > >>> that don't use xscreensaver." > >>> > >>> Seems like it would just get rid of some warnings? But > >>> whatever, definitely an improvement > >>> > >> For systems that don't use the xscreesaver, gaim_gtk_get_time_idle didn't > >> return anything, causing a compile-warning, and causing the idle-tracking > >> to not work (idle.c:check_idle would get zero and hence not show up > >> as idle). > >> > >> This is one instance where getting rid of a warning message also > >> fixes a bug (albeit a very small one). > >> > >> -- Adil > > > > Ah, the compile-warning problem didn't occur to me. But there is no > > 'check_idle' in idle.c. There is a 'check_idleness', however it shouldn't > > ever call 'idle_ui_ops->get_time_idle();' when xscreensaver is disabled > > because the idle UI ops are not set when xscreensaver is disabled. Unless I'm > > missing something. > > > > -Mark > > > Aren't we doing fallback to Gaim idle tracking when xscreensaver is > unavailable? > > Kevin Yes, and it's all handled in core code. If the idle UI ops are not set then we use Gaim idle. -Mark |