From: Stu T. <st...@no...> - 2005-01-18 16:39:01
|
On Mon, 2005-01-17 at 20:03, Mark Doliner wrote: > Anyone have any ideas? see below. > On Mon, 17 Jan 2005 19:31:41 +0100 (CET), Pekka Riikonen wrote > > ----- > > diff -u -r1.33 silc.c > > --- silc.c 13 Jan 2005 23:37:04 -0000 1.33 > > +++ silc.c 17 Jan 2005 18:30:29 -0000 > > @@ -359,7 +359,7 @@ > > for (l = gaim_get_conversations(); l; l = l->next) > > { > > conv = l->data; > > - if (gc == conv->account->gc) > > + if (conv && gc == conv->account->gc) > > gaim_conversation_destroy(conv); > > } > > ----- This whole block seems wrong to me, no prpl should need to actively destroy conversations on logout. Also, the list returned by gaim_get_conversations could be invalidated after the first call to gaim_conversation_destroy because gaim_conversation_destroy does: conversations = g_list_remove(conversations, conv); I suspect *that* is why conv is NULL in Luke's crash. My suggestion would be to remove this block that is destroying conversations, unless there's a legitimate reason for it. Regards, Stu. |