Re: [Phpwiki-talk] latest build

[Jan H. <hi...@wi...>]

On Wed, Dec 06, 2000 at 09:30:28PM +0100, Arno Hollosi wrote:
> On Wednesday 06 December 2000 20:09, Steve Wainstead wrote:
> > Oh yes, I saw that too last night and forgot to report it.
> > sw
> >
> > On Wed, 6 Dec 2000, Jan Hidders wrote:
> > > I tried the latest nightly build (December 6) and now I see in my pages
> > > things like ³#IF ADMIN³# and ³#IF LOCK³#. But perhaps this is a matter
> > > of work in progress?
> 
> I cannot verify this. I just downloaded the latest tarball and did a clean 
> install and cannot find any of this.

I have found the problem. In the function _iftoken in stdlib.php the
removal of line based directives is done with

  	    $page = ereg_replace("{$lineno}[^\n]*\n", '', $page);
and

	    $page = ereg_replace("{$lineyes}[^\n]*\n", '', $page);

But the brackets around $lineno and $lineyes are wrong. It should be

  	    $page = ereg_replace("${lineno}[^\n]*\n", '', $page);
and

	    $page = ereg_replace("${lineyes}[^\n]*\n", '', $page);

I don't know why you didn't notice anything. The problem is only visible for
directives that are "false" and are not within a block directive that is
"false". Perhaps you only checked pages where there are no such directives.

-- Jan Hidders