Re: [Phpwiki-talk] assert ...

[Reini U. <ru...@x-...>]

Dan Frankowski schrieb:
> You didn't cc the list, so I do.
> Jim Cheetham wrote:
>> Thanks to both Dan and Frederik for confirming my thoughts about 
>> assert(), and expanding on them :-)
>>
>> With respect to turning these off in production, my question becomes :-
>>
>> Should phpwiki have active assert statements for production users? Can 
>> we turn them off with the equivalent of DEBUG = 0, or via .htaccess 
>> setting a php value?
> 
> Reini changed this in CVS so DEBUG=0 turns off assert()s.
> 
>> and
>>
>> Given that I've seen WikiDB getRevisionBefore($version) throw out an 
>> assert when submitting a page edit (on a dba=file wiki), does that 
>> indicate a problem that needs to be fixed, either in phpwiki or on my 
>> site?

Which phpwiki version? Thanks for the report.

But I think found the error, which is fixed in current CVS.
$backend->get_previous_version() returns false instead of 0, which hurts 
getRevisionBefore().

> Yes. Either in the code or in the assert.

For sure in phpwiki. asserts are so simple that they cannot be wrong.
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/