#258 SERVER_NAME should be HTTP_HOST so relative links work.

[Dave Truby]

Version 1.3.7,
In file ./lib/config.php,
in line number 250,
currently has

if (!defined('SERVER_NAME')) define('SERVER_NAME',
$HTTP_SERVER_VARS['SERVER_NAME']);

this causes the local server's hostname to be used in
all links. It should use the dns name that the browser
address requested so that relative addressing resolves
all links in the wiki page. Changing the above line 250 to

if (!defined('SERVER_NAME')) define('SERVER_NAME',
$HTTP_SERVER_VARS['HTTP_HOST']);

fixes this bug.

So the SERVER_NAME php variable should not use
$HTTP_SERVER_VARS['SERVER_NAME']
but should use
$HTTP_SERVER_VARS['HTTP_HOST']
.

[Joseph (Joby) Walker]

Logged In: YES
user_id=171834

There is no bug.

'SERVER_NAME' is the cannonical name for the webserver.
This is the name that the administrator has defined, and
thus by using this definition we are giving the
administrator default power to determine the link
composition. Additionally, if SSL is used the server name
in the URL needs to match the name in the certificate --
which if configured properly will be 'SERVER_NAME'.

If we set it to 'HTTP_HOST', we are giving power to the
client which we should not do by default. This can be
overridden in the config settings (currently in index.php).

But no matter which of these constants we use all links
should resolve just fine. If there is a relative link --
'HTTP_HOST' will be used be used because it is the client
browser that composes the full URL.

jbw