phpweather-devel

How about this?

[Martin G. <gim...@gi...>]

Hi everybody

To make sure we're talking about the same thing, I went and
implemented mine idea :-) I haven't commited the changes to CVS
because I wanted to hear the reactions first. Instead, I've uploaded
the files to gimpster.com:

  http://www.gimpster.com/downloads/

I've changed some things: the class metar_parser is now known as
phpweather, and the former phpweather class has been removed.

I've put the output modules in a subdirectory called - surprise -
output. They're called 'pw_type_xx.php' where type is something like
'text' or 'images' and xx is the language-code.

I stored the icons in a directory called 'images'. I figured that
'images' are more generic, and we might have more images in the
future.

All the above is just a suggestion - we can change everything if you
have any objections. So, please download the tarball and tell me what
you think.

=2D-=20
Martin Geisler                       My GnuPG Key: 0xF7F6B57B

See my homepage at http://www.gimpster.com/ for:
PHP Weather =3D> Shows the current weather on your webpage.
PHP Shell   =3D> A telnet-connection (almost :-) in a PHP page.

RE: How about this?

[Max H. <ma...@fl...>]

Hi all,

> To make sure we're talking about the same thing, I went and
> implemented mine idea :-) I haven't commited the changes to CVS
> because I wanted to hear the reactions first. Instead, I've uploaded
> the files to gimpster.com:

Looks good to me.

> I stored the icons in a directory called 'images'. I figured that
> 'images' are more generic, and we might have more images in the
> future.

Okay, but I think that it would make sense to keep the icons seperate from
any future images - they do play one specific role. Perhaps put them in a
subdirectory of images if you really want?

> All the above is just a suggestion - we can change everything if you
> have any objections. So, please download the tarball and tell me what
> you think.

Looks good to me. I'd suggest that you move the icons and then commit it.

Max

Re: How about this?

[Martin G. <gim...@gi...>]

"Max Hammond" <ma...@fl...> writes:

Hi everybody,

> [...]
>
> Looks good to me. I'd suggest that you move the icons and then
> commit it.

OK - watch out for the mails at the phpweather-checkins list :-)

=2D-=20
Martin Geisler                       My GnuPG Key: 0xF7F6B57B

See my homepage at http://www.gimpster.com/ for:
PHP Weather =3D> Shows the current weather on your webpage.
PHP Shell   =3D> A telnet-connection (almost :-) in a PHP page.