phpweather-devel

PHP Weather 2?

[Martin G. <gim...@gi...>]

Hi everybody

As those of you who follow the phpweather-checkins mailing list will
know, I've been adding and deleting files from CVS today. I've also
made a number of small corrections.

My plan is to finally make a release of the code in CVS. I've been
using it on Gimpster.com for some months now without problems.

I'm very happy with most of the code, although I've discovered that
the text output can be improved. The 'problem' is that many of the
strings are put together like this:

  $output = $strings['foo'] . $var_a .
            $strings['bar'] . $var_b .
            $strings['baz'] . $var_c;

instead of this

  $output = sprintf($strings['foobarbaz'], $var_a, $var_b, $var_c);

The advantage of the last method is, that the translator can make
$var_c come before $var_a in the final string. Changing this requires
updates of the translations, but it shouldn't be that hard to do since
it's mostly a matter of moving and combining existing strings.

There's also currently three open bug reports, but they're not too
serious. And if we wait until all bugs are fixed, then we'll never be
able to release anything.

So, please update from CVS and see if you can spot any problems. Mail
back tomorrow with your comments.

-- 
Martin Geisler                       My GnuPG Key: 0xF7F6B57B

See http://gimpster.com/ and http://phpweather.net/ for:
PHP Weather => Shows the current weather on your webpage and
PHP Shell   => A telnet-connection (almost :-) in a PHP page.

Re: PHP Weather 2?

[Gyulai Miha'ly <gy...@fb...>]

Martin Geisler =EDrta, 2002-08-26, 19:09-kor kelt level=E9ben, ami 39=
 sorb=F3l =E1llt:

>   $output =3D sprintf($strings['foobarbaz'], $var_a, $var_b, $var_c=
);
>=20
> The advantage of the last method is, that the translator can make
> $var_c come before $var_a in the final string.

Maybe that would be good.

> please update from CVS and see if you can spot any problems. Mail
> back tomorrow with your comments.
=20
I did the CVS update and tested it. I wonder how the "HTML iso-code"
could be modified by the selected language?

The iso-8859-1 is not suitable for Hungarian, we use iso-8859-2.
Is it possible to do? The selected City appears without accents...

--=20
Mih=E1ly Gyulai http://gyulai.freeyellow.com/

Re: PHP Weather 2?

[Martin G. <gim...@gi...>]

Gyulai Miha'ly <gy...@fb...> writes:

> Martin Geisler =EDrta, 2002-08-26, 19:09-kor kelt level=E9ben, ami 39 sor=
b=F3l =E1llt:
>=20
>>   $output =3D sprintf($strings['foobarbaz'], $var_a, $var_b, $var_c);
>>=20
>> The advantage of the last method is, that the translator can make
>> $var_c come before $var_a in the final string.
>=20
> Maybe that would be good.

I've found out that this is the normal way of doing things using
gettext.
=20
>> please update from CVS and see if you can spot any problems. Mail
>> back tomorrow with your comments.

By the way: Ondrej Jombik has some changes that we'll incorporate
before the release, so the release will probably not happen tomorrow
after all.
=20=20
> I did the CVS update and tested it. I wonder how the "HTML iso-code"
> could be modified by the selected language?

The index.php file should already do this properly by sending the
right header:

  header('Content-Type: text/html; charset=3D' . $text->get_charset());

This makes the output contain all sorts of accents.
=20
> The iso-8859-1 is not suitable for Hungarian, we use iso-8859-2. Is
> it possible to do? The selected City appears without accents...

You mean in the drop-down list? That's right - there's no accents in
that, but that's mostly because the city names doesn't have any
accents in stations.csv.

I'm not sure if we want characters in stations.csv that doesn't belong
to ISO-8859-1. The thing is: what should the browser do, when it's
displaying text in Danish (using ISO-8859-1) but sees a Hungarian city
with characters from ISO-8859-2?

I've played a little with this before, but here goes again: could we
just use Unicode (UTF-8?) for all files instead of this mess with
different encodings for different files?

I don't have any experience with this, but from what I've heard, then
Unicode is supposed to solve these problems.

--=20
Martin Geisler                       My GnuPG Key: 0xF7F6B57B

See http://gimpster.com/ and http://phpweather.net/ for:
PHP Weather =3D> Shows the current weather on your webpage and
PHP Shell   =3D> A telnet-connection (almost :-) in a PHP page.