Re: pw_text_cs, pw_text_nl & couple of suggestions

[Martin G. <gim...@gi...>]

Vaclav Rikal <va...@ph...> writes:

> Hello there!
> 
> first of all I'd like to say that you have done a great job. I'm
> using a phpweather for one and half year and progress is _really_
> great!

Thanks a lot!
 
> I'd like to participate on it. So I'm sending you a czech and dutch
> pw_text_cs.php, pw_text_nl.php.

Very nice - two new languages in one go! I've commited then to the CVS
repository.
 
> Than I suggest to add a more CZ stations:
> 
> LKLB -> Liberec
> LKKB -> Praha / Kbely
> LKPD -> Pardubice
> LKCV -> Caslav
> LKCS -> Ceske Budejovice
> LKNA -> Namest
> LKPO -> Prerov
> LKKU -> Kunovice

I checked the stations, but they don't seam to have made any recent
reports: the report for LKKB is over two months old. Do you think I
should add them anyway?
 
> And I think the rule in pw_text_en is broken:
> 
>    $this->strings['list_sentences_and']       = ' and ';
>    $this->strings['list_sentences_comma']     = ', ';
>    $this->strings['list_sentences_final_and'] = ', and ';
>                                                   ^^^^^^^^^^^ Here

Are you thinking at the comma before the final 'and'? Or is it
something else? If it's about the final comma, then that's how my
teacher taught me to write a list in English - perhaps someone who
has English as their mother tongue could comment on this?

-- 
Martin Geisler                       My GnuPG Key: 0xF7F6B57B

See http://gimpster.com/ and http://phpweather.net/ for:
PHP Weather => Shows the current weather on your webpage and
PHP Shell   => A telnet-connection (almost :-) in a PHP page.