Re: SQL failures, new navigation system and other things
Brought to you by:
iridium
From: Ondrej J. <ne...@po...> - 2002-08-30 01:19:18
|
Maxim, 02:14:38 30. august 2002 (piatok) Greetings. > > So conclusion: addslasles on strings inserted into DB is > > *always* good idea. Problem may occur only if string is addslashed > > twice or more times. > Yes, exactly. I think the easiest way to handle this is to let the > methods in the db backends be the only methods to add slashes. All > other methods should not have to care about this. So also icao should be stored as-is without starting addslashes() call used? I will be for this. Ugly stripslashes() hack when using icao as substitution for human readable station name could be than removed. But IMHO this should be done after comming release. It is not majority problem. > > I tried it for MySQL and PostgreSQL and it worked well. I also tried > > this "new" version of phpWeather on my site and again without > > problems (I only change get_country() for get_country_code() call). > Good - that should be the only change necessary. > Does this mean that we're ready to release the code? From my point of view yes. That was all things I had actual for phpWeather. Others after release. But maybe someone other has also something... I will try to find some time for submiting things (comments/bugs) on SF, just for remembering them. =Nepto= ____________________________________________________________________________ "Be conservative in what you do, be liberal in what you accept from others." (RFC 793: Transmission control protocol; chapter 2.10. Robustness Principle) |