Re: SQL failures, new navigation system and other things

[Ondrej J. <ne...@po...>]

                                        Maxim, 02:09:20
                                        28. august 2002 (streda)
Greetings.

> If you plan to continue in this pace, then why don't get yourself a
> CVS account? I can add nepto as a developer if you're interested...

	Yes, that's not bad idea. It should make 2.x development slight 
flexible and faster. So I'm interested. Thanks.

> > 	This e-mail contains three problems described, with solution
> > written. Patches are also included.
> I've looked at the patches and I like them - especially the KISS
> principle :-) But why have you rewritten all the SQL statements to use
> sprintf() to embed the variables instead of using either "foo $var
> bar" or 'foo ' . $var . ' bar'?

	I have answer for this. When I sterted with implementation of
described things, I didn't know that $icao is already escaped (addslashed).  
So I glace at queries and see that I need to add addsleshes($icao) into
almost every query. But than I said, why not to rewrite all of them to be
more readable?

	I must admin that finally it was unneccessary. Sorry for that, but I
think that buinding queries with sprintf() gets more readability. I like
this way.

> Apart from that, I'll probably commit them tomorrow (or to be correct:
> later today, it's getting late... :-) I'm sure that I can patch the
> null and dba database backends to handle the lookup for country code.

	Thanks. I was affraid that I will study DBA interface. Without 
get_country() method in pw_db_dba.php it will not works. That's fact.

	Regards,

	=Nepto=
____________________________________________________________________________
Ondrej 'Nepto' Jombik, Visit Atlantis talker now!        http://atlantis.sk/