Re: SQL failures, new navigation system and other things

[Martin G. <gim...@gi...>]

Ondrej Jombik <ne...@po...> writes:

>                                         Maxim, 19:19:39
>                                         27. august 2002 (utorok)
> Greetings again!
> 
> 	Today I implemented things I was talking about yesterday. As
> it was written, I wanted them and I'm usign them on my website (I
> will pass URL tomorrow evening). But I also suppose that you will be
> interested in them too.

I'm very interested - and I want to thank you for the time you put
into PHP Weather. The patches and suggestions are coming faster than I
can get time to read them :-)

If you plan to continue in this pace, then why don't get yourself a
CVS account? I can add nepto as a developer if you're interested...
 
> 	This e-mail contains three problems described, with solution
> written. Patches are also included.

I've looked at the patches and I like them - especially the KISS
principle :-) But why have you rewritten all the SQL statements to use
sprintf() to embed the variables instead of using either "foo $var
bar" or 'foo ' . $var . ' bar'?

Apart from that, I'll probably commit them tomorrow (or to be correct:
later today, it's getting late... :-) I'm sure that I can patch the
null and dba database backends to handle the lookup for country code.

-- 
Martin Geisler                       My GnuPG Key: 0xF7F6B57B

See http://gimpster.com/ and http://phpweather.net/ for:
PHP Weather => Shows the current weather on your webpage and
PHP Shell   => A telnet-connection (almost :-) in a PHP page.