Various issues

[Ondrej J. <ne...@po...>]

                                        Maxim, 22:53:21
                                        26. august 2002 (pondelok)
Greetings!

	Yesterday I started to integrate phpWeather into my website and I 
have few notes, comments and questions.

1. There is a little translation bug in index.php file. See patch below:

--- index.php.ori       Fri May 31 00:26:12 2002
+++ index.php   Mon Aug 26 22:55:16 2002
@@ -86,7 +86,7 @@
       '" height="40" width="40" border="1" alt="Current wind in ' .
       $weather->get_location() . '" /> ' .
       '<img src="' . $icons->get_temp_image() .
-      '" height="50" width="20" border="1" alt="Current weather in ' .
+      '" height="50" width="20" border="1" alt="Current temperature in ' .
       $weather->get_location() . '" />' .
       "\n</blockquote>\n" .
       "<p>The raw METAR is <code>" .

2. I want to suggest removal of hidden "old" input fields from functions in
pw_utilities.php file. I wanted generaly not to use annoying "old" variables
stuff, but I want use these support functions as well. I think that someone
who wants use these old variables, can always include them in his/her form.
After this change IMHO these functions became more usuable. Patch follows:

--- pw_utilities.php.ori        Thu Mar 28 16:49:09 2002
+++ pw_utilities.php    Mon Aug 26 11:20:14 2002
@@ -15,7 +15,6 @@
     }
   }
   $output .= "\n</select>\n";
-  $output .= '<input type="hidden" name="old_cc" value="' . $old_cc . '" 
/>';
   return $output;
 }

@@ -35,8 +34,6 @@
     }
   }
   $output .= "\n</select>\n";
-  $output .= '<input type="hidden" name="old_icao" value="' .
-    $old_icao . '" />';

   return $output;
 }
@@ -55,10 +52,8 @@
     }
   }
   $output .= "\n</select>\n";
-  $output .= '<input type="hidden" name="old_language" value="' .
-    $old_language . '" />';

   return $output;
 }

-?>
\ No newline at end of file
+?>

3. I want also suggest better navigation system in index.php. I implemented
it only with variables $cc and $icao. There is no need for "old"  variables
($old_cc, $old_icao). In wednesday I will be hopefully able to show you it
on live page. I haven't got uploaded it now.

4. This issue is connected with previous one. Navigation system should be
even easier, if we will implement some DB method that will returns country
for defined icao. Than three types of page should be shown:

	a. default one with no variables (shows default country in combo 
	   box and no stations) (example: /index.php)
	b. stations combo box with first station selected + country selected 
	   in country combo box (example: /index.php?cc=SK)
	c. country selected, station selected, appropriate weather printed 
	   (example: /index.php?icao=LZTT)

	Algorith is basically simple: check if $cc is set, if it is, show
also stations select. Also check if $icao is iset, if it is, set particular
$cc and print particauler weather for $icao. All we need is one DB method,
that will return country ($cc) for station ($icao).

	I will be able to implement this for mysql (I *will* do it, because
I *want* this navigation system), but I do not know what about others RDBM
systems.

5. I want also ask if there will some weather picture for "no data
available". Temperature and wind, both, have this special case solved.

6. In my MySQL database I have two stations for my country (SK) in stations
table. But in file db/files/SK.php there are 7 airports. Have someone got
idea how has been this desynchornization created and how to solve it? I will
appreciate it a lot.

	I'm sorry that I came with these issues just before comming release,
but I did not know about that.

	Thanks,

	=Nepto=
____________________________________________________________________________
Ondrej 'Nepto' Jombik, perl -le '$_=1;(1x$_)!~/^(11+)\1+$/&&print while$_++'