Re: CVS: phpweather/output pw_text.php,1.11,1.12 pw_text_da.php,1.4,1.5 p...

[Martin G. <gim...@gi...>]

Max Hammond <ir...@us...> writes:

> Update of /cvsroot/phpweather/phpweather/output
> In directory usw-pr-cvs1:/tmp/cvs-serv3089
>=20
> Modified Files:
> 	pw_text.php pw_text_da.php pw_text_en.php pw_text_hu.php=20
> 	pw_text_no.php=20
> Log Message:
> Combined windchill and heatindex into one 'feels like' - sorry
> translators. I think this is a better solution

Yes, it's a good solution. I see that you have updated the various
translation with the English string - why don't we just subclass
pw_text_en instead?

So pw_text_da should extend pw_text_en instead of pw_text. And the
Norwegian translation could even extend the Danish one - the Danish
strings are pretty similar to the Norwegian ones.

The downside of this is, that the PHP engine has to parse more files
before it can do any work. But I'm not sure that this is something
that we should be worried about - I've seen sites that included 5000
lines of PHP code in every page, so the extra ~200 lines in pw_text_en
shouldn't make that big a difference.

If noone objects, then I'll do the change. At the same time, then it
would be cool to have a script that could check the translations for
missing strings.

=2D-=20
Martin Geisler                       My GnuPG Key: 0xF7F6B57B

See my homepage at http://www.gimpster.com/ for:
PHP Weather =3D> Shows the current weather on your webpage.
PHP Shell   =3D> A telnet-connection (almost :-) in a PHP page.