Re: Bug

[Martin G. <gim...@gi...>]

"Ray van Beek" <r_v...@ho...> writes:

>> But if $weather_str is left as the empty string, then it shouldn't
>> be able to sneak 'Current weather is' into the report :-)
>> $weather_str is copied directly to the output, it's not prefixed
>> with 'Current weather' or anything like that.
> 
> ..snip...
>   if (isset($data['weather'])) {
>     $weather_str = sprintf($strings['current_weather'], $data['weather']);
>  } else {
>     $weather_str = '';
>  }
> ..snip...

Ahh - now I see it. The test should be if (!empty($data['weather']))
so that the empty string is considered false...

I'll fix that in the next release. We should also have your beautiful
icons with in that release - the current weather and wind icons look
great. (See http://www.devolder.nl/cgibin/phpweather/table.php)

Judging from your temperature table-cell in the bottom of your page,
are you working on some sort of thermometer? You know: a little glass
one with red mercury rising with the temperature. I think that would
be a great addition to the other icons.

-- 
Martin Geisler                       My GnuPG Key: 0xF7F6B57B

See my homepage at http://www.gimpster.com/ for:
PHP Weather => Shows the current weather on your webpage.
PHP Shell   => A telnet-connection (almost :-) in a PHP page.