Does not properly detect Microsoft Netshow. This
project seemed good at first, but the way you have
written and implemented the preg's makes it SLOW
when compared to strstr operations (which can be used
to detect 95% of the requests). Also, you have limited
yourselves due to the single regexp for picking up
browser version strings. Another thing... the more
browsers you detect, the fatter your preg_match_all
gets, and the poorer the performance across *all*
browsers (since you have to test ALL expressions).
This is a perfect example of a bunch of goof-balls who
think they're PHP hotshots, gone awry. Instead, you
provide a poor example of how to code this type of
function, but your preg stuff will no doubt impress the
beginner (who's never had to optimize code before).
Good luck to you...
Logged In: NO
Thanks for the constructive criticism. Much appreciated.
Logged In: NO
Microsoft NetShow is not a browser, maybe thats why its not
detected.
This is where you would provide further information on the
problem so maybe the developers of this software could
approach the problem.
Lastly, you are talking out of your arse. You provide
abstract claims without any clear evidence to back them up.
This is a perfect example of someone who will be providing
optimized detection software using strstr, with no limits,
5% regexs, and able to detect Netshow. Good luck to you.
A satisifed user of phpSniff.