Thread: [phpslash-users] PHP3 Block fix - Request for Comments
Brought to you by:
joestewart,
nhruby
From: Joe S. <jo...@be...> - 2001-01-10 19:39:10
|
Hey, I changed the getParser so that it keeps the class instances to get around the lack of class_exists in PHP3. Anybody have problems with the code below? If you can improve, please speak up. It's been working OK for Matt and I through minimal testing. Joe replacement getParser: function getParser($mytype) { /* Start a new object to render info */ $parserName = "Block_render_" . $mytype; $parserFile = $parserName . ".class"; static $parser_arr; if( !$parser_arr[$mytype]) { include($parserFile); $parser_arr[$mytype] = new $parserName; } $parser_arr[$mytype] = new $parserName; } diff to previous Block.class: diff -u phpslash-ft/public_html/Block.class Block.class --- phpslash-ft/public_html/Block.class Thu Dec 14 08:40:18 2000 +++ Block.class Wed Jan 10 09:24:57 2001 @@ -277,23 +277,16 @@ $parserName = "Block_render_" . $mytype; $parserFile = $parserName . ".class"; - $php_majorversion = floor(phpversion()); + static $parser_arr; - /* workaround for php3/php4 conflicts. php3 doesn't have the get_class - or class_exists functions */ - if ($php_majorversion >= 4) { - if (get_class($parser_arr[$mytype]) != $parserName) { - if (!class_exists($parserName)) { - include($parserFile); - } - $parser_arr[$mytype] = new $parserName; - } - $this->parser = $parser_arr[$mytype]; - } else { - include($parserFile); + if( !$parser_arr[$mytype]) { + + include($parserFile); $parser_arr[$mytype] = new $parserName; - $this->parser = $parser_arr[$mytype]; + } + $this->parser = $parser_arr[$mytype]; + } function doParse($autoStore) { |
From: tobozo <to...@io...> - 2001-01-11 11:47:38
|
Hi Joe, You Wrote : > Hey, I changed the getParser so that it keeps the class instances to get > around the lack of class_exists in PHP3. Anybody have problems with the > code below? If you can improve, please speak up. It's been working OK > for Matt and I through minimal testing. The version of phpslash 5.3.2 I'm talking about resides on a php 3.0.7 and cannot be moved, the server cannot be upgraded... The issue is with php 3.0.7, the problem resides on the preg_*() functions calls in the Block.class and the template.inc (damn!). I know php 3.0.9 is required, but is there any way I could predefine these preg_* functions ? The xmlparser.class exists as a replacement to the xml module for php, I guess there must be something like this for the regex set of functions somewhere but I just couldn't find it... Should I stay 5.3.2 or should I go to hell ? t. cqfd ----- Original Message ----- From: "Joe Stewart" <jo...@be...> To: "PHPslash list" <php...@li...> Sent: Wednesday, January 10, 2001 7:36 PM Subject: [phpslash-users] PHP3 Block fix - Request for Comments |
From: Matt \TrollBoy\ W. <tro...@sh...> - 2001-01-11 13:30:59
|
perhaps I'm oing something wrong on the submission page but, I edited the story, put it in a section and a topic, hit save, and it oesn't show up on index.ohp3, is there something I'm forgetting or not doing? -- Matt "Trollboy" Wiseman www.shoggoth.net/trollboy/trollboy.jpg Tro...@sh... "I wish the world had one throat!!" -Al Bundy |
From: nathan r. h. <nh...@ar...> - 2001-01-11 14:27:59
|
Matt TrollBoy Wiseman wrote: > perhaps I'm oing something wrong on the submission page but, I edited the > story, put it in a section and a topic, hit save, and it oesn't show up on > index.ohp3, is there something I'm forgetting or not doing? > Is it posted in the Home section? IF not it'll only pop up when you hit a index.php3?section=FOO. Remember that you can have a story in multiple sections -n -- ........ nathan hruby Webmaster: UGA Department of Drama and Theatre Project Maintainer: phpSlash, Carousel nh...@ar... ........ |
From: Matt \TrollBoy\ W. <tro...@de...> - 2001-01-11 19:39:27
|
hmm.. just for usability, we may want to have it default add the home section in there, with perhaps a check box to disable that.. just my 2 bits Matt "Trollboy" Wiseman www.shoggoth.net/trollboy/trollboy.jpg Tro...@sh... "I wish the world had one throat!!" -Al Bundy ----- Original Message ----- From: "nathan r. hruby" <nh...@ar...> To: "Matt TrollBoy Wiseman" <tro...@sh...> Cc: <php...@li...> Sent: Thursday, January 11, 2001 9:26 AM Subject: Re: [phpslash-users] story admin > Matt TrollBoy Wiseman wrote: > > > perhaps I'm oing something wrong on the submission page but, I edited the > > story, put it in a section and a topic, hit save, and it oesn't show up on > > index.ohp3, is there something I'm forgetting or not doing? > > > > Is it posted in the Home section? IF not it'll only pop up when you hit > a index.php3?section=FOO. Remember that you can have a story in > multiple sections > > -n > > > > > -- > ........ > nathan hruby > Webmaster: UGA Department of Drama and Theatre > Project Maintainer: phpSlash, Carousel > nh...@ar... > ........ > |
From: nathan r. h. <nh...@ar...> - 2001-01-11 20:44:55
|
----- Original Message ----- From: "Matt "TrollBoy" Wiseman" <tro...@de...> To: "nathan r. hruby" <nh...@ar...>; "Matt TrollBoy Wiseman" <tro...@sh...> Cc: <php...@li...> Sent: Thursday, January 11, 2001 11:40 AM Subject: Re: [phpslash-users] story admin > hmm.. just for usability, we may want to have it default add the home > section in there, with perhaps a check box to disable that.. just my 2 bits > Wouldn't that just be the inverse of the way it is now? Not seeing how that affects usability.. -n > > ----- Original Message ----- > From: "nathan r. hruby" <nh...@ar...> > To: "Matt TrollBoy Wiseman" <tro...@sh...> > Cc: <php...@li...> > Sent: Thursday, January 11, 2001 9:26 AM > Subject: Re: [phpslash-users] story admin > > > > Matt TrollBoy Wiseman wrote: > > > > > perhaps I'm oing something wrong on the submission page but, I edited > the > > > story, put it in a section and a topic, hit save, and it oesn't show up > on > > > index.ohp3, is there something I'm forgetting or not doing? > > > > > > > Is it posted in the Home section? IF not it'll only pop up when you hit > > a index.php3?section=FOO. Remember that you can have a story in > > multiple sections > > > > -n > > > > > > > > > > -- > > ........ > > nathan hruby > > Webmaster: UGA Department of Drama and Theatre > > Project Maintainer: phpSlash, Carousel > > nh...@ar... > > ........ > > > |