phpslash-devel — For developers of phpslash to communicate.

[Phpslash-devel] stripBadHTML bug - well kinda

[Mike G. <mi...@op...>]

Hello,

The bug with stripBadHTML is that it doesn't manage one user error that
a client of mine stumbled across.

<br><a href="link>1missing last</a> - Missing the last quote here
<br><a href="link">2fine</a> - Messes up this quote here

I'm not the best at regular expressions, but I would think that it would
be possible to check that both ""'s are present:

   $str = eregi_replace("<a([^>]*)href=\"?([^\"]*)\"?([^>]*)>",
                         "<a href=\\2>", $str);

It's waiting for the final " (which in this case the user forgot).

It should look for either the final " or a final > (whichever comes
first).  I would think that this would do it:
	
   $str = eregi_replace("<a([^>]*)href=\"?([^\"]*)[\"|>]?([^>]*)>",
                         "<a href=\\2>", $str);

But I haven't gotten it to work just right...

I know this isn't something that many folks are likely to do, but for
this type of interface it's good to correct simple typos if you can..

Mike
-- 
Mike Gifford, OpenConcept Consulting
Free Software for Social Change -> http://www.openconcept.ca
Site Launch - Make Every Vote Count - http://www.fairvotecanada.org
The cruelest lies are often told in silence. -- Robert L Stevenson

Re: [Phpslash-devel] doctype & html verification

[Joe S. <joe...@us...>]

On Wed, Jul 16, 2003 at 06:26:58PM -0400, Luis M wrote:
> 
> >Playing with
> >
> >http://validator.w3.org/check/referer
> >
> >gives me a bad feeling.
> >slashHead.tpl declares a doctype of
> >
> >"-//W3C//DTD HTML 4.0 Transitional//EN"
> >
> >but does
> >
> ><link ... />
> >
> >just a few lines below. A quick
> >
> >grep '/ *>' *.tpl
> >
> >shows a lot of this strange XML code.
> >
> >Is this just an oversight?
> 
> At some point I believe that this templates were validated. I remember 
> somebody talking about that here in the -devel (or was it -users) list.
> I think is time to move on to "4.01 Strict" and do some of those strange 
> things that look like XML but are actually somewhere in the gray area 
> (XHTML?). For instance, the infamous: < br /> . And similar tags.
>

I think I may have done this while correcting the IE6/centering problem
and didn't finish and change it back.

> I also play a lot with the validator, but if something looks good on 
> Mozilla, I don't even bother to check it. IE guys are out of luck :-) The 
> good thing is that Mozilla does "the right thing" most of the time (except 
> for those < blink > tags and other crap people tend to use in other pages, 
> not us here in phpslash :-) ).
> 
> The right thing to do is to pull the phpslash-dev module from CVS and play 
> with it and submit patches -- or totally new skins from phpslash-skin 
> module.
> 

If you check out the skins from the phpslash-skin cvs and they aren't
working, most of them need {TOP} and {BOTTOM} placeholders added to the
index templates.


> Just my .02 contrib...
> 
> 
> P.D. #phpslash on irc.freenode.net is always open for comment. Joe and 
> others, including myself, regularly hang on that channel.
> 

yup

Joe.

> ----)(-----
> Luis Mondesi
> System Administrator
> LatinoMixed.com
> 
> le...@ho...
> 
> "...The Mac does this so smoothly, it feels like an extension of your 
> mind." - Paula Speer, MacWorld Magazine 2003-04
> 
> Public signature: http://www.latinomixed.com/lems1/public-a.asc
> 
> _________________________________________________________________
> MSN Messenger : discutez en direct avec vos amis ! 
> http://www.msn.fr/msger/default.asp
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: VM Ware
> With VMware you can run multiple operating systems on a single machine.
> WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the
> same time. Free trial click here: http://www.vmware.com/wl/offer/345/0
> _______________________________________________
> Phpslash-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpslash-devel

Re: [Phpslash-devel] i18n

[Joe S. <joe...@us...>]

On Wed, Jul 16, 2003 at 06:37:32PM -0400, Luis M wrote:
> >
> >I use phpslash-0.7.2 for a German speaking site.
> >Consequently I need a complete translation.
> >As far as I see, the procedure is as follows:
> >
> 
> I do the spanish translation (most of the time) and I can relate to you on 
> this...
> 
> >Once you find a string in a template you
> >1. create a entry in include/locale/en.php
> >2. put a translation in include/locale/de.php
> >3. make up a macro name
> >4. substitute the string with the macro name, across all themes
> >5. have a look for the template file name in *.php and add
> >   a pslgetText statement to "$template->set_var"
> 
> That's 100% right. Although I believe that we are trying to move all 
> strings out of the .tpl files and more to the "locale" files. That way we 
> won't have to make too many corrections in different templates/$LANG 
> directories. However, that happens and we do have lots of strings still 
> flying around the .tpl files. More on this Joe?
> 

I'm still of the opinion that much of the text is easier to modify and
translate if it stays in the tpl.  That way it is in the context that it
will be displayed.

> >
> >Of course the string can occur more than once in multiple
> >templates. In some languages the translation can be different,
> >according to context, though.
> >
> >a) What directory should I diff against?
> >   phpslash-ft/public_html/templates/en
> 
> phpslash-ft is the old module which makes the current stable release. It's 
> being slowly face out -- pretty much the migration is done I would say. We 
> still work on -dev and "backport" things to phpslash-ft when necessary, but 
> -dev is so ahead of the game that it's a matter of time before we move on 
> to -dev to make releases. However, Joe would ultimately be the guy to ask 
> in this manner. To be safe, work on -dev always and diff against that.
> 

I guess it kind of depends on what you are working on.  Preferably we
would be working to get the -dev release ready.  But if you're only
running the -ft, patches against it are fine.

> >   or
> >   phpslash-dev/include/templates/en
> >

Whichever.  We'll work the patches in.

> >b) Is there a system behind template macro names?
> 
> ditto.
> 

don't think so.  If someone wants to help with an API doc and update the
coding guidelines, that would be great.

> >
> >c) How should I handle different word order or higher
> >   macro levels? For example
> >
> >   from the {DEPT} dept.
> >
> >   is translated as
> >
> >   Aus der Abteilung {DEPT}
> 
> Usually this has to be done in the order that's more natural to the given 
> language. For as long as that makes perfect sense to you who speak natively 
> that language, go ahead and submit it like you think is better. Usually I 
> give grammar explanations on my locale translations (as comments) in case 
> somebody looks at a string and dislike the translation; however, I welcome 
> corrections if they are necessary.
> 

Definitely you should be able to output text with grammar that makes sense
in that language.  If there is some difficulty in doing this, please point
it out.  You may decide that a language specific template set is best.

thanks,

Joe

> ----)(-----
> Luis Mondesi
> System Administrator
> LatinoMixed.com
> 
> le...@ho...
> 
> "...The Mac does this so smoothly, it feels like an extension of your 
> mind." - Paula Speer, MacWorld Magazine 2003-04
> 
> Public signature: http://www.latinomixed.com/lems1/public-a.asc

Re: [Phpslash-devel] i18n

[Luis M <le...@ho...>]

>
>I use phpslash-0.7.2 for a German speaking site.
>Consequently I need a complete translation.
>As far as I see, the procedure is as follows:
>

I do the spanish translation (most of the time) and I can relate to you on 
this...

>Once you find a string in a template you
>1. create a entry in include/locale/en.php
>2. put a translation in include/locale/de.php
>3. make up a macro name
>4. substitute the string with the macro name, across all themes
>5. have a look for the template file name in *.php and add
>    a pslgetText statement to "$template->set_var"

That's 100% right. Although I believe that we are trying to move all strings 
out of the .tpl files and more to the "locale" files. That way we won't have 
to make too many corrections in different templates/$LANG directories. 
However, that happens and we do have lots of strings still flying around the 
.tpl files. More on this Joe?

>
>Of course the string can occur more than once in multiple
>templates. In some languages the translation can be different,
>according to context, though.
>
>a) What directory should I diff against?
>    phpslash-ft/public_html/templates/en

phpslash-ft is the old module which makes the current stable release. It's 
being slowly face out -- pretty much the migration is done I would say. We 
still work on -dev and "backport" things to phpslash-ft when necessary, but 
-dev is so ahead of the game that it's a matter of time before we move on to 
-dev to make releases. However, Joe would ultimately be the guy to ask in 
this manner. To be safe, work on -dev always and diff against that.

>    or
>    phpslash-dev/include/templates/en
>
>b) Is there a system behind template macro names?

ditto.

>
>c) How should I handle different word order or higher
>    macro levels? For example
>
>    from the {DEPT} dept.
>
>    is translated as
>
>    Aus der Abteilung {DEPT}

Usually this has to be done in the order that's more natural to the given 
language. For as long as that makes perfect sense to you who speak natively 
that language, go ahead and submit it like you think is better. Usually I 
give grammar explanations on my locale translations (as comments) in case 
somebody looks at a string and dislike the translation; however, I welcome 
corrections if they are necessary.

----)(-----
Luis Mondesi
System Administrator
LatinoMixed.com

le...@ho...

"...The Mac does this so smoothly, it feels like an extension of your mind." 
- Paula Speer, MacWorld Magazine 2003-04

Public signature: http://www.latinomixed.com/lems1/public-a.asc

_________________________________________________________________
MSN Messenger : discutez en direct avec vos amis ! 
http://www.msn.fr/msger/default.asp

Re: [Phpslash-devel] doctype & html verification

[Luis M <le...@ho...>]

>Playing with
>
>http://validator.w3.org/check/referer
>
>gives me a bad feeling.
>slashHead.tpl declares a doctype of
>
>"-//W3C//DTD HTML 4.0 Transitional//EN"
>
>but does
>
><link ... />
>
>just a few lines below. A quick
>
>grep '/ *>' *.tpl
>
>shows a lot of this strange XML code.
>
>Is this just an oversight?

At some point I believe that this templates were validated. I remember 
somebody talking about that here in the -devel (or was it -users) list.
I think is time to move on to "4.01 Strict" and do some of those strange 
things that look like XML but are actually somewhere in the gray area 
(XHTML?). For instance, the infamous: < br /> . And similar tags.

I also play a lot with the validator, but if something looks good on 
Mozilla, I don't even bother to check it. IE guys are out of luck :-) The 
good thing is that Mozilla does "the right thing" most of the time (except 
for those < blink > tags and other crap people tend to use in other pages, 
not us here in phpslash :-) ).

The right thing to do is to pull the phpslash-dev module from CVS and play 
with it and submit patches -- or totally new skins from phpslash-skin 
module.

Just my .02 contrib...


P.D. #phpslash on irc.freenode.net is always open for comment. Joe and 
others, including myself, regularly hang on that channel.

----)(-----
Luis Mondesi
System Administrator
LatinoMixed.com

le...@ho...

"...The Mac does this so smoothly, it feels like an extension of your mind." 
- Paula Speer, MacWorld Magazine 2003-04

Public signature: http://www.latinomixed.com/lems1/public-a.asc

_________________________________________________________________
MSN Messenger : discutez en direct avec vos amis ! 
http://www.msn.fr/msger/default.asp

[Phpslash-devel] doctype & html verification

[Alexander B. <ale...@ba...>]

Playing with

http://validator.w3.org/check/referer

gives me a bad feeling.
slashHead.tpl declares a doctype of

"-//W3C//DTD HTML 4.0 Transitional//EN"

but does

<link ... />

just a few lines below. A quick 

grep '/ *>' *.tpl

shows a lot of this strange XML code.

Is this just an oversight? 
             

[Phpslash-devel] i18n

[Alexander B. <ale...@ba...>]

I use phpslash-0.7.2 for a German speaking site.
Consequently I need a complete translation.
As far as I see, the procedure is as follows:

Once you find a string in a template you
1. create a entry in include/locale/en.php
2. put a translation in include/locale/de.php
3. make up a macro name
4. substitute the string with the macro name, across all themes
5. have a look for the template file name in *.php and add
   a pslgetText statement to "$template->set_var"

Of course the string can occur more than once in multiple
templates. In some languages the translation can be different,
according to context, though.

a) What directory should I diff against?
   phpslash-ft/public_html/templates/en
   or
   phpslash-dev/include/templates/en

b) Is there a system behind template macro names?

c) How should I handle different word order or higher
   macro levels? For example

   from the {DEPT} dept.

   is translated as

   Aus der Abteilung {DEPT} 
             

Re: [Phpslash-devel] Very minor debugging suggestion for lib.resources.php

[Matthew L. <lei...@ma...>]

Hi,

Still unpacking but checking e-mail...

On Thu, 10 Jul 2003, Joe Stewart wrote:

> On Thu, Jul 10, 2003 at 10:57:39AM -0400, Mike Gifford wrote:
> > Howdy,
> >
[snip!]
> > You can't pass arrays to the debug function very well..  I
suppose you
> > could serialize them so
> > 	debug('List of classes',serialize(get_declared_classes()));
> >
> > In anycase just a thought..
> >
>
> Hey Mike,
>
> debug() should have no trouble outputting arrays.  This works fine for me:
>
> 	debug("declared_classes", get_declared_classes());

I agree.  debug() got rewritten for 0.7 to recurse through arrays and
objects.

> What is the value of debug.max_recursion_level in config.ini?
>
> 	debug.max_recursion_level = 10

This was a guard against circular references.  Consider:

$a = new Parent;
$b = new Child;

$a->children[] =& $b;
$b->parent =& $a;

debug("a",$a);

This would go on indefinitely without either (a) a check for circularity
or (b) a maximum level to recurse to.  I didn't really know how to do (a)
so I built in (b).  I believe if you set
$_PSL['debug.max_recursion_level'] to something negative then you can get
arbitrary recursion (with no circularity checks).

But anyway, the array returned from get_defined_classes should only be
one-dimensional, so 10 is fine for the purpose!

--Matt
----------------------------------------------------------------
Matthew Leingang		617/495-2171
Harvard University		lei...@ma...
Department of Mathematics	"This signature needs no quote."

Re: [Phpslash-devel] Very minor debugging suggestion for lib.resources.php

[Mike G. <mi...@op...>]

Sorry Gents..  

On Thu, 2003-07-10 at 13:18, Matthew Leingang wrote:
> On Thu, 10 Jul 2003, Joe Stewart wrote:
> > debug() should have no trouble outputting arrays.  This works fine for me:
> >
> > 	debug("declared_classes", get_declared_classes());
> I agree.  debug() got rewritten for 0.7 to recurse through arrays and
> objects.

Good to know debug can handle both arrays & objects..  Sorry for
overlooking that..

> > What is the value of debug.max_recursion_level in config.ini?>
> > 	debug.max_recursion_level = 10
> This was a guard against circular references.  Consider:
> But anyway, the array returned from get_defined_classes should only be
> one-dimensional, so 10 is fine for the purpose!

Yes, but would this be a useful addition to pslNew:
	debug("declared_classes", get_declared_classes());

(which was the point of the email - I just underestimated the abilities
of debug)

Mike	
-- 
Mike Gifford, OpenConcept Consulting
Free Software for Social Change -> http://www.openconcept.ca
Featured Client: CUPE National -> http://www.cupe.ca
Whoever controls the media-the images-controls the culture - A. Ginsberg

Re: [Phpslash-devel] Very minor debugging suggestion for lib.resources.php

[Joe S. <joe...@us...>]

On Thu, Jul 10, 2003 at 10:57:39AM -0400, Mike Gifford wrote:
> Howdy,
> 
> in lib.resources.php, the function pslNew could be slightly easier to
> debug in the future if the declared classes could be output more easily:
> 
>    else {
>       // print_r(get_declared_classes());
>       pslError("No such class: $class");
>       return false;
>    }
> 
> I was trying to figure out why the heck pslNew wasn't working for a new
> class I was developing and finally figured out that I hadn't quite
> changed the class name correctly....  
> 
> You can't pass arrays to the debug function very well..  I suppose you
> could serialize them so 
> 	debug('List of classes',serialize(get_declared_classes()));
> 
> In anycase just a thought..
> 

Hey Mike,

debug() should have no trouble outputting arrays.  This works fine for me:

	debug("declared_classes", get_declared_classes());

What is the value of debug.max_recursion_level in config.ini?

	debug.max_recursion_level = 10

If you add a test like this do you get the full array displayed?

	debug("_PSL", $_PSL);

Joe

> Mike
> -- 
> Mike Gifford, OpenConcept Consulting
> Free Software for Social Change -> http://www.openconcept.ca
> Featured Client: CUPE National -> http://www.cupe.ca
> Whoever controls the media-the images-controls the culture - A. Ginsberg
> 

[Phpslash-devel] Very minor debugging suggestion for lib.resources.php

[Mike G. <mi...@op...>]

Howdy,

in lib.resources.php, the function pslNew could be slightly easier to
debug in the future if the declared classes could be output more easily:

   else {
      // print_r(get_declared_classes());
      pslError("No such class: $class");
      return false;
   }

I was trying to figure out why the heck pslNew wasn't working for a new
class I was developing and finally figured out that I hadn't quite
changed the class name correctly....  

You can't pass arrays to the debug function very well..  I suppose you
could serialize them so 
	debug('List of classes',serialize(get_declared_classes()));

In anycase just a thought..

Mike
-- 
Mike Gifford, OpenConcept Consulting
Free Software for Social Change -> http://www.openconcept.ca
Featured Client: CUPE National -> http://www.cupe.ca
Whoever controls the media-the images-controls the culture - A. Ginsberg

Re: [Phpslash-devel] Second argument of psl_getLocalInfo

[Joe S. <joe...@us...>]

On Fri, Jun 20, 2003 at 09:29:56PM +0200, Alexander Bartolich wrote:
> There is a file called config.php (according to installation guide).
> On
> 
> http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/
> 
> I guess it's really
> 
> phpslash/phpslash-ft/public_html/config-dist.php3
> 
> Anyway, somewhere around line 640 is a strange call of psl_getLocalInfo:
> 
> define("ALLSECTIONS", "section_id0");
> 
> if ($_PSL['timezone']['engine']) {
>   loadLibrary("tz");
>   // set up the time zone environment array
>   $_TZ =& $_PSL['timezone'];
>   $_TZ['templatedir'] = $_PSL['templatedir'];
>   $_TZ['show_format'] = psl_getLocalInfo('LC_TIME','%a %b %e %H:%M:%S %Z
> %Y');
> 
> This second argument looks like a "query by example".
> None of the files in class/locale define a key like that.
> Consequently psl_getLocalinfo (yes, lower case i in function.php) first
> tries to load
> de.LC_TIME.php and then falls back to en_US.LC_TIME.php.
> 
> What's that good for?
> 

Matt told me that it is to format the time display in tz_select.php.  I think 
we can move a similar line to tz_select.php and out of the config file for 
all pages.

The tz_select.php functionality doesn't require a user account.  How should 
this be integrated into phpSlash?  The user profile page is only available to 
logged in users.  This is where I had been leaning to add it in.

Joe

Re: [Phpslash-devel] Second argument of psl_getLocalInfo

[Joe S. <joe...@us...>]

On Fri, Jun 20, 2003 at 09:29:56PM +0200, Alexander Bartolich wrote:
> There is a file called config.php (according to installation guide).
> On
> 
> http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/
> 
> I guess it's really
> 
> phpslash/phpslash-ft/public_html/config-dist.php3
> 
> Anyway, somewhere around line 640 is a strange call of psl_getLocalInfo:
> 
> define("ALLSECTIONS", "section_id0");
> 
> if ($_PSL['timezone']['engine']) {
>   loadLibrary("tz");
>   // set up the time zone environment array
>   $_TZ =& $_PSL['timezone'];
>   $_TZ['templatedir'] = $_PSL['templatedir'];
>   $_TZ['show_format'] = psl_getLocalInfo('LC_TIME','%a %b %e %H:%M:%S %Z
> %Y');
> 
> This second argument looks like a "query by example".
> None of the files in class/locale define a key like that.
> Consequently psl_getLocalinfo (yes, lower case i in function.php) first
> tries to load
> de.LC_TIME.php and then falls back to en_US.LC_TIME.php.
> 
> What's that good for?
>

uh - I don't see that it is used at all.  It looks like it's trying to find 
that string in the time formats for some reason.
 
Matt, you around?

[Phpslash-devel] Re: Phpslash-devel digest, Vol 1 #204 - 11 msgs

[Mike G. <mi...@op...>]

Howdy Folks,

> > This might be a good time to talk about extending this to a plugin
> > system to allow other text manipulation.  Things like wiki style,
> > BBcode, link annotation, glossary links, etc.
> backEnd recently got a WikiText and a few other nice things like that.  we
> should look and see if we can steal that ;-)

You should absolutely steal that :)  There are a number of other ideas
that the team had to extend this and make it more useful too.  We've
also added on htmlArea for folks who want to work in a WYSIWYG.  The
alpha release of the code works with Mozilla.
	http://mozile.mozdev.org/

Was really hopeful about composite, but that seemed to have died..

> eg: www.foo.com/phpslash/help.php?modifyStory would open up a simple no
> decorations window and pull some descriptive text either from a file (like
> the phpslash SGML manual) or database... I think a small script that opens
> up the manaual and jumps to the correct anchor would be the neatest thing
> as the script could know where in the manaual we need to go, and all the
> docs remain int he same place.

We're looking for something like this in BE too. Something where we can
insert help logos through the app and have people quickly get the info
they are looking for or find out what x or y does.

Mike
-- 
Mike Gifford, OpenConcept Consulting
Free Software for Social Change -> http://www.openconcept.ca
Featured Client: CUPE National -> http://www.cupe.ca
Whoever controls the media-the images-controls the culture - A. Ginsberg

[Phpslash-devel] Second argument of psl_getLocalInfo

[Alexander B. <ale...@gm...>]

There is a file called config.php (according to installation guide).
On

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/

I guess it's really

phpslash/phpslash-ft/public_html/config-dist.php3

Anyway, somewhere around line 640 is a strange call of psl_getLocalInfo:

define("ALLSECTIONS", "section_id0");

if ($_PSL['timezone']['engine']) {
  loadLibrary("tz");
  // set up the time zone environment array
  $_TZ =& $_PSL['timezone'];
  $_TZ['templatedir'] = $_PSL['templatedir'];
  $_TZ['show_format'] = psl_getLocalInfo('LC_TIME','%a %b %e %H:%M:%S %Z
%Y');

This second argument looks like a "query by example".
None of the files in class/locale define a key like that.
Consequently psl_getLocalinfo (yes, lower case i in function.php) first
tries to load
de.LC_TIME.php and then falls back to en_US.LC_TIME.php.

What's that good for?

-- 
+++ GMX - Mail, Messaging & more  http://www.gmx.net +++
Bitte lächeln! Fotogalerie online mit GMX ohne eigene Homepage!

[Phpslash-devel] Re: [Back-end-development] Annoying Problem with stripBadHTML

[Mike G. <mi...@op...>]

Hello Sam,

I've cc'd the slash development list.

On Thu, 2003-06-19 at 23:14, Sam Williams wrote:
> On Fri, 2003-06-20 at 02:38, Mike Gifford wrote:
> > In cutting/pasting it in sections it seemed to get hung up on:
> > 	<a 
> > 	name=Baird></a><br>
> > After removing all of these hanging <a's I was able to paste it in
> > without difficult.  I just had to remove a number of them.
> I seem to remember having problems with this function in phpSlash a
> while back.
> At a guess, I would say that the newline, LF or LF/CR character pair
> (which it is depends on whether the text came from Windows, Unix or Mac)
> after the <a are messing up the regex matching. 

Yup.  

> Looking at (an old version of) the function, I don't think the lines
> designed to 'standardise' html tags will match a hanging tag:
> 
> $str = eregi_replace("<[[:space:]]*([^>]*)[[:space:]]*>","<\\1>",$str);
> $str = eregi_replace("<a([^>]*)href=\"?([^\"]*)\"?([^>]*)>",
> 	"<a href=\\2>", $str);

This is from the phpSlash CVS version:
$str = eregi_replace("<[[:space:]]*([^>]*)[[:space:]]*>","<\\1>",$str);
$str = eregi_replace("<a([^>]*)href=\"?([^\"]*)\"?([^>]*)>",
                         "<a href=\\2>", $str);

> and I don't think this will either:
> while (eregi("<([^> ]*)([^>]*)>",$str,$reg)) {

I'm not a regex expert, but I can't see why this would be interrupted by
a line break...  

> A quick fix would be another eregi_replace that strips all newline, LF
> and CR characters from within tags before anything else is done with the
> string.

Yes, but that would make it very difficult to edit afterwards, right?

> Perhaps it's time to update the stripBadHTML so that it uses the native
> PHP function that was introduced in 3.0.8: 

I'd be in favour of moving this way.  I would think it would speed up
the code to have the processing done by native php functions.

> string strip_tags ( string str [, string allowable_tags])   

What it doesn't allow is the degree of control that stripBadHTML
presently offers.  The ability to allow tags or tags and definitions is
nice.  Mind you I don't know how many folks use that.

> I'm not sure how well this works compared to the phpslash code, but it
> is much more readable :-). This is probably something for the
> phpSlash-devel list...

It doesn't seem to be a problem in phpSlash.  the line break doesn't
seem to interfere with the code.

Mike
-- 
Mike Gifford, OpenConcept Consulting
Free Software for Social Change -> http://www.openconcept.ca
Featured Client: CUPE National -> http://www.cupe.ca
Whoever controls the media-the images-controls the culture - A. Ginsberg

Re: [Phpslash-devel] RFE: [ 740043 ] RSS blocks options

[Luis M <le...@ho...>]

>Luis requested that the rss feed item descriptions have a method for
>being disabled.  We couldn't find that this was already available
>except for removing the description from the template.
>
>http://sourceforge.net/tracker/index.php?func=detail&aid=740043&group_id=10566&atid=360566
>
>Two new block options for this were added:
>
>description = on - display item description [default]
>               off - do not display item description
>
>and
>
>channel_description = on - display item channel description [default]
>                       off - do not display item channel description
>
>Any problem here?  Pretty handy.
>
>http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/phpslash/phpslash-dev/include/modules/block/blocktypes/Block_render_rss.class.diff?r1=1.4&r2=1.2

Sweet!

Now it's a matter of trying it out with bad RSS feeds (those who want to 
send everything in a single feed) like eWeek.com!

_________________________________________________________________
MSN Search, le moteur de recherche qui pense comme vous ! 
http://search.msn.fr/worldwide.asp

[Phpslash-devel] RFE: [ 740043 ] RSS blocks options

[Joe S. <joe...@us...>]

Luis requested that the rss feed item descriptions have a method for 
being disabled.  We couldn't find that this was already available 
except for removing the description from the template.

http://sourceforge.net/tracker/index.php?func=detail&aid=740043&group_id=10566&atid=360566

Two new block options for this were added:

description = on - display item description [default]
              off - do not display item description

and 

channel_description = on - display item channel description [default]
                      off - do not display item channel description

Any problem here?  Pretty handy.

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/phpslash/phpslash-dev/include/modules/block/blocktypes/Block_render_rss.class.diff?r1=1.4&r2=1.2

Joe

Re: [Phpslash-devel] yet more suggestions for .73...

[Joe S. <joe...@us...>]

On Sat, May 10, 2003 at 07:32:08PM -0400, Luis M wrote:
> 
> ummm it seems that posting code to an article causes phpslash to parse the 
> code. This makes yet another suggestion for the future release:
> 
> #. Do not parse code coming from articles.
> 
> Things like having $php variables, or {VAR} containers for templates... They 
> should all be escaped if the text comes from an article. That could 
> potentially eliminate all types of cross-site scripting and sql-code 
> injection that <i>might</i> be lurking in the phpslash code...
> 
> At least people should have the option to turn code parsing off, in case 
> somebody actually wants to allow this for his/her site.
> 
> Suggestions?
>

So let's backup and define what you need to happen when posting 
code.

1. text contained in {} should not be parsed.  Is this the case with 
all story input?  I kinda think so.  Solutions here can get kind a 
goofy.  Any suggestions?

2. indenting preserved with <pre> </pre>?

3. html in the code to be converted and not displayed as html?

Instead of just acting during the save process, should this happen 
with a button that applies immediately to the form entry field and a 
preview?  Don't know if it's very feasible or not.

 
> P.S. For the meantime I'll try to escape as much as I can by hand (as I 
> usually do).
> 

Do you have to escape it all again if you modify the article?

Joe

Re: [Phpslash-devel] yet more suggestions for .73...

[Luis M <le...@ho...>]

>From: "nathan r. hruby" <na...@ds...>
>To: Luis M <le...@ho...>
>CC: <na...@ds...>, <php...@li...>
>Subject: Re: [Phpslash-devel] yet more suggestions for .73...
>Date: Mon, 12 May 2003 13:13:31 -0700 (PDT)
>
>
>Hi Luis!
>
>On Sun, 11 May 2003, Luis M wrote:
>
> > The code I'm trying to publish is here:
> > ftp://ftp.latinomixed.com/downloads/pixdir2html.pl.gz
> >
> > The only thing I did to that code was to run "cat -n" and save this as a
> > .txt file with line numbers like this:
> > gunzip pixdir2html.pl.gz
> > cat -n pixdir2html.pl > pixdir2html.pl.txt
> >
> > And then try to use the resulting .txt file to make a new story.
> >
>
>I did this exact same procudure.. comment below
>
> > I placed a screenshot of a preview story here:
> > http://www.latinomixed.com/story-preview-screenshot.jpg
> >
>
>Humm I get something different, but my templates are different from yours.
>
> > Note that this screenshot shows only the first page of the page, the 
>page is
> > a lot longer than this, and it's all garble all the way up to the end. 
>Let
> > me know if you want to see more of the screen so that I can make more
> > screenshots.
> >
>
>The problem I'm seeing is that the resulting preview and story pages will
>get odd if you post that perl script as either plaintext or HTML and it
>contains HTML that conflicts with the rest of the page (eg head, body,
>etc.. tags)  when I preview it on my ShankZen derived test install, it
>starts getting weird at line 31, and each successive html tag causes
>things to get odder.
>
>The solution to this is to post the story as exttrans the first time you
>post it so all of the HTML is translated into the proper entities..
>However, it does appear that posting as plaintext or HTML and then trying
>to change the story to exttrans after the fact seems to not work which
>is a bug.
>
>Can you try to make a new story with this text and post it (without a
>preview) as exttrans?
>

Tried that, this is how it "works":

1. post the text to a new story and hit ExtraTrans when saving. When check 
the story, it looked garbled. So that didn't work.

2. post the story without the code mentioned earlier. then went to "modify" 
and copy the code to the story body portion. after that hit "extratrans" 
when previewing (saving it directly didn't work either) and then got a nice 
preview of how things should work... then I hit save and things get scramble 
again... @#$@#%. I hit save using both "html" and "extratrans" and neither 
worked.


Obviously this is a bug.


----)(-----
Luis Mondesi
System Administrator
LatinoMixed.com

le...@ho...

"...The Mac does this so smoothly, it feels like an extension of your mind." 
- Paula Speer, MacWorld Magazine 2003-04

Public signature: http://www.latinomixed.com/lems1/public-a.asc

_________________________________________________________________
MSN Search, le moteur de recherche qui pense comme vous ! 
http://search.msn.fr/worldwide.asp

Re: [Phpslash-devel] yet more suggestions for .73...

[nathan r. h. <na...@ds...>]

On Mon, 12 May 2003, Joe Stewart wrote:

> On Mon, May 12, 2003 at 01:13:31PM -0700, nathan r. hruby wrote:
> >
>
> <snip!>
> > Can you try to make a new story with this text and post it (without a
> > preview) as exttrans?
> >
>
> Actually the form says "New Story Options:" to indicate they apply
> only to new stories.  It's just a way of being cowardly and avoiding
> screwed up articles with no undo function.  It can easily be changed
> to apply to both new and edited articles.
>

Heh :)  That's what I get for not reading it right!  This works for some
case but not all (eg: exttrans -> html -> extrans ) conversion would get
weird quick.

> This might be a good time to talk about extending this to a plugin
> system to allow other text manipulation.  Things like wiki style,
> BBcode, link annotation, glossary links, etc.
>

backEnd recently got a WikiText and a few other nice things like that.  we
should look and see if we can steal that ;-)

> The story options already allows extensions like this for the
> display side I think.  But nothing as far as text conversion when
> saving.
>

It could be messy.  I don't think there's anythign wrong with with the way
it works, other than a lack of a warning in the Modify Story menu.  One
thing I;d like to do is go through the interface and add additional help
text/hints/explinations for various features.  things are better now, but
still could use some work.  This might be better with a simple system
that opens a popup window containing help text for the page..

eg: www.foo.com/phpslash/help.php?modifyStory would open up a simple no
decorations window and pull some descriptive text either from a file (like
the phpslash SGML manual) or database... I think a small script that opens
up the manaual and jumps to the correct anchor would be the neatest thing
as the script could know where in the manaual we need to go, and all the
docs remain int he same place.

-n

-- 
------
nathan hruby
na...@ds...
------

Re: [Phpslash-devel] Really dumb question

[Joe S. <joe...@us...>]

On Sun, May 11, 2003 at 10:09:20AM -0700, nathan r. hruby wrote:
> On Sun, 11 May 2003, Joe Stewart wrote:
> 
> >
> > There are a few things I've been doing outside the Makefile temporarily.
> >
> > I think this is all:
> >
> > run extch.sh
> > copy config-dist.php to config.php
> > rename db_xfer.php3.disabled to db_xfer.php.disabled
> > copy phplib into class directory
> > make dist
> >
> 
> Makes sense
> 
> > I haven't scripted this because when I tried to keep a snapshot with the
> > extchg.sh step, I couldn't keep a local repository w/php3 and a release w/php.
> >
> 
> Well, there's no reason we can't change the Makefile's dist target to
> do all of that and make a snap taget that doesn't extch, right?
>

True.  I just had no success doing this and stopped trying for 
awhile.
 
Joe

> -n
> 
> -- 
> ------
> nathan hruby
> na...@ds...
> ------
> 

Re: [Phpslash-devel] yet more suggestions for .73...

[Joe S. <joe...@us...>]

On Mon, May 12, 2003 at 01:13:31PM -0700, nathan r. hruby wrote:
> 

<snip!> 
> Can you try to make a new story with this text and post it (without a
> preview) as exttrans?
> 

Actually the form says "New Story Options:" to indicate they apply 
only to new stories.  It's just a way of being cowardly and avoiding 
screwed up articles with no undo function.  It can easily be changed 
to apply to both new and edited articles.

This might be a good time to talk about extending this to a plugin 
system to allow other text manipulation.  Things like wiki style, 
BBcode, link annotation, glossary links, etc.

The story options already allows extensions like this for the 
display side I think.  But nothing as far as text conversion when 
saving.

Joe

> Thanks,
> 
> -n
> -- 
> ------
> nathan hruby
> na...@ds...
> ------
> 

Re: [Phpslash-devel] yet more suggestions for .73...

[nathan r. h. <na...@ds...>]

Hi Luis!

On Sun, 11 May 2003, Luis M wrote:

> The code I'm trying to publish is here:
> ftp://ftp.latinomixed.com/downloads/pixdir2html.pl.gz
>
> The only thing I did to that code was to run "cat -n" and save this as a
> .txt file with line numbers like this:
> gunzip pixdir2html.pl.gz
> cat -n pixdir2html.pl > pixdir2html.pl.txt
>
> And then try to use the resulting .txt file to make a new story.
>

I did this exact same procudure.. comment below

> I placed a screenshot of a preview story here:
> http://www.latinomixed.com/story-preview-screenshot.jpg
>

Humm I get something different, but my templates are different from yours.

> Note that this screenshot shows only the first page of the page, the page is
> a lot longer than this, and it's all garble all the way up to the end. Let
> me know if you want to see more of the screen so that I can make more
> screenshots.
>

The problem I'm seeing is that the resulting preview and story pages will
get odd if you post that perl script as either plaintext or HTML and it
contains HTML that conflicts with the rest of the page (eg head, body,
etc.. tags)  when I preview it on my ShankZen derived test install, it
starts getting weird at line 31, and each successive html tag causes
things to get odder.

The solution to this is to post the story as exttrans the first time you
post it so all of the HTML is translated into the proper entities..
However, it does appear that posting as plaintext or HTML and then trying
to change the story to exttrans after the fact seems to not work which
is a bug.

Can you try to make a new story with this text and post it (without a
preview) as exttrans?

Thanks,

-n
-- 
------
nathan hruby
na...@ds...
------

Re: [Phpslash-devel] yet more suggestions for .73...

[Luis M <le...@ho...>]

Hello,
Read...

<snip>

>I have tried this with the current CVS (and current php-lib-stable cvs)
>using both the nobody user / submission page and as a root user using the
>story admin page and cannot replicate this behavior using extrans, html
>or plaintext formats using Safari-b2.

I'm using phpslash 0.71 with the latest Mozilla 1.3 build for debian 
unstable.

>
>Please, what versions of phpslash, phplib and php are you running?  Does
>the above exmaple work exactly as you describe under your environment?
>Can you take a screengrab of whhat you enter into the page and what the
>preview looks like?  Can you send me the extact text that caused this?

phplib that came with the phpslash 0.71 release. (phplib 0.7d ? ). php 4.3 
and php 4.1.2 both do exactly the same (two different instalations).

>
> > The {td} part of the hashes will mess up the article badly when 
>previewing.
> > In fact, the whole page gets mumble with all kinds of crazy things. What 
>I
> > do to fix that is adding spaces between the curly-braces.
> >
>
>Clearly that should not happen.
>
> > I don't think this affects the server directly, nor have I try to inject 
>any
> > type of code to the database. In other words, I'm assuming this cannot 
>be
> > done and have not tried. In any case, only the users with Admin rights 
>can
> > add news to the site. So, nothing to worry (right?).
> >
>
>If this is a real bug, it may also affect the submission.php page...
>
> > However, I believe that the stories (the text coming from the database 
>to be
> > displayed as stories) should not be parse as if it was a template or as 
>if
> > dynamic PHP code was coming from the database... That could create 
>problems.
> > (It creates problems for people who have sites publishing code, as I do 
>:-)
>
>The input stuff should clean() the text before it even gets to the
>database.  the {} construct is also the same for phplib tempalte
>plcasehoder, AFIK, things that look like {foo} get removed during parsing
>by the template system and should be additionally fixed by the submission
>and story classes.  Joe probably knows how this works off the top of his
>head..

The code I'm trying to publish is here:
ftp://ftp.latinomixed.com/downloads/pixdir2html.pl.gz

The only thing I did to that code was to run "cat -n" and save this as a 
.txt file with line numbers like this:
gunzip pixdir2html.pl.gz
cat -n pixdir2html.pl > pixdir2html.pl.txt

And then try to use the resulting .txt file to make a new story.

I placed a screenshot of a preview story here:
http://www.latinomixed.com/story-preview-screenshot.jpg

Note that this screenshot shows only the first page of the page, the page is 
a lot longer than this, and it's all garble all the way up to the end. Let 
me know if you want to see more of the screen so that I can make more 
screenshots.

----)(-----
Luis Mondesi
System Administrator
LatinoMixed.com

le...@ho...

"...The Mac does this so smoothly, it feels like an extension of your mind." 
- Paula Speer, MacWorld Magazine 2003-04

Public signature: http://www.latinomixed.com/lems1/public-a.asc

_________________________________________________________________
MSN Search, le moteur de recherche qui pense comme vous ! 
http://search.msn.fr/worldwide.asp