[Phpslash-devel] Re: [Phpslash-commit] CVS: phpslash-dev CHANGES,1.75,1.76

[Joe S. <joe...@us...>]

On Wed, Jul 07, 2004 at 10:56:13AM -0700, Peter Cruickshank wrote:

Thanks for the flood of commits.

>   
> + 2004-July 7 Peter Cruickshank <kr...@us...>
> + [B]  slashTemplate.class:
> +      Comment out portion of code that was causing infinite recursion when attempting
> +      to find default skins template

Sorry you had to spend time figuring out what's going on there.

How did you trigger this?  A missing template file?  I haven't had a problem with 
it in months.  I think at one point I had it commented out as well.

Any ideas on how to make this more simple while maintaining the flexibility?  The 
PEAR version of phplib templates creates an array of possible locations.  But if I 
remember it is doesn't allow on the fly changes like we have.

> + [B]  author/index.php:
> +      Check for existance of jpcache_gc function before attempting to call it

surely that is that last one.

> + [F]  Block_render_header.class
> +      Make section name available to slashHead template. (There may be a more elegant
> +      way of doing this)

yipes.  Looks like we weren't using the $extra_ary argument to getHeader.  I think 
$_PSL['extra_ary'] can still be used though.  With these two arrays you can apply 
arbitrary text to be template variables.

We might want to change section->getName to generate a db object so it could be 
called like Section::getName.

So is the breadcrumb the page block not generating the section name?  Or is it not 
called before this?  This was subtly how the section name would be available 
before.  It would still need to be applied to extra_ary or pagetitle to be 
available in getHeader though.  This is one reason there hasn't been a breadcrumb 
block yet.  If breadcrumb isn't required, it probably should be made a block 
somehow.

> + [BW] Block_render_query.class
> +      Fix generation of topic_id and section_id plus some minor tidyup of logic
> + [W]  Block_render_topic.class
> +      Tidy up logic - incl move parse_str to top of parse()
> + [W]  search/index.php section/admin.php topic/admin.php
> +      Notice squashing
> + [W]  Section.class, Topic.class
> +      Improvements to logic + presentation of validation process
> + 

>       // I am not sure if this check makes sense from the user's point of view
>       // - it's a real pain deleting all the blocks one at a time.
>       // Much better to just silently clear out psl_section_block_lut I think
>       // - pac Jul-2004

I think I tend to agree, but it doesn't bother me too much the way it is either 
when deleting sections.  Don't tend to delete sections often.

Joe